Ci fixes#112
Open
akutuva21 wants to merge 4 commits into
Open
Conversation
…test mocks
- bngfile.py: replaced conf.get('stdout') with self.suppress (conf was
removed in the upstream deferred-app-setup refactor)
- test_csimulator.py: patch get_conf() instead of the removed module-level
conf attribute, matching the upstream csimulator architecture
…s_to_bngparser add_empty_block creates empty block attributes but does not populate active_blocks (only the real parser does that via add_block with an argument). The test needs active_blocks populated so bngmodel.__init__ does not raise BNGModelError before reaching the assertion.
…asses_path_options_to_bngparser The merged code now passes verbose=self.verbose to BNGParser, so the expected call must include verbose=False for the default case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You merged the last PR too early before CI completed, so here's some small updates to ensure it passes