Fix transitive verbal cluster split (fixes #1261)#1262
Merged
bnmnetp merged 1 commit intoJun 26, 2026
Merged
Conversation
Member
|
Did you do this against the PR with the function and unit tests? |
sethbern
force-pushed
the
fix/1261-transitive-verbal-clusters
branch
from
f958180 to
7a3be60
Compare
Contributor
Author
|
I rebased onto main so the fix is now inside split_ab_conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #1261. It replaces the per-seed union approach with a union-find (connected components) pass so transitively-linked verbal groups.