Add Source::loudness via ebur128#895
Draft
4wn51dq wants to merge 2 commits into
Draft
Conversation
Adds a `loudness` feature that wraps the ebur128 crate in a passthrough Source exposing momentary, short-term, and integrated LUFS. Includes integration tests and a changelog entry. Refs RustAudio#757
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps the
ebur128crate (a pure-Rust port of libebur128) behind a newloudnessfeature flag, exposing EBU R128 / ITU-R BS.1770 loudness measurement as a passthroughSourceadapter.Source::loudness()— chains onto any source, passes audio through unchangedmomentary_lufs()(400 ms),short_term_lufs()(3 s),integrated_lufs()(gated, whole-program)64bitfeatureWhat's included
src/source/loudness.rs— the adaptertests/loudness.rs— 4 integration tests (plausible LUFS, silence, louder-is-higher, stereo passthrough)Cargo.toml—loudness = ["dep:ebur128"]feature + optional dependencyCHANGELOG.mdentryWhat's not included (yet)
SpanTrackerintegration for mid-stream sample rate / channel changesTest plan
cargo test --lib --features loudness(75 pass)cargo test --test loudness --features loudness(4 pass)cargo test --doc --features loudness(68 pass)cargo clippy --all-features -- -D warningscargo fmt --checkloudness+64bitcombinedRefs #757