Repository navigation
Conversation
Params 10, 11 and 12 become WINDOW_PASSENGER, WINDOW_REAR_LEFT and WINDOW_REAR_RIGHT, matching driverWindow, passengerWindow, rearLeftWindow and rearRightWindow in the vehicle status. WINDOW_2, WINDOW_3 and WINDOW_4 stay as aliases, so existing code keeps working. Nothing sent to the car changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names the door window params after the status model.
Changes
RvcParamsId: params 10, 11 and 12 becomeWINDOW_PASSENGER,WINDOW_REAR_LEFTandWINDOW_REAR_RIGHT.WINDOW_2,WINDOW_3andWINDOW_4stay as aliases, so existing code keeps working.VehicleWindowId: getsPASSENGER,REAR_LEFTandREAR_RIGHT, with the old names kept as aliases.control_windowsandcontrol_door_windowsuse the new names.tests/test_door_window_names.pychecks the new IDs, the aliases, and thatcontrol_windowssends the same bytes.Why
The vehicle status reports
driverWindow,passengerWindow,rearLeftWindowandrearRightWindow.WINDOW_2,WINDOW_3andWINDOW_4say nothing about which window they are.Draft: the order is inferred
The mapping 9 = driver, 10 = passenger, 11 = rear left, 12 = rear right follows the order of the status fields. It is not confirmed. Keep this as a draft until it is checked against the app or a capture, ideally on a right-hand-drive car (compare #51/#52, where the front seats turned out to be physical sides).
The old names are kept as aliases either way, so nothing breaks if a name changes later.
https://claude.ai/code/session_013xKSpu8ev4cxQNsitcCidm