Repository navigation
fix: end the heated seat and steering wheel commands with PARAMS_MAX - #57
Merged
Merged
Conversation
The iSmart app appends parameter 255 to these commands. Send it with the value 0, encoded like the other control commands, so they follow the app and the rest of the client. Door windows are unchanged: the app sends no 255 there.
|
@nanomad, I tested #57 on my MG S6 EV (UK, iOS app). Both commands work with the 255 marker:
They also work without it, which is how the iOS app sends them in my capture, and how mg-saic-ha has sent them since September. So the car accepts either, and you're right that it's harmless. One thing worth knowing for the status: with the wheel on, the car reports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ends the heated seat and heated steering wheel commands with
PARAMS_MAX(param 255), like the other control commands.Changes
control_heated_steering_wheel: sends{24: 1 or 0, 255: 0}(was{24}).control_heated_seat: sends{seat, 255: 0}(was{seat}).control_heated_seats, climate and rear window heat.control_door_windowsis unchanged.Why
The iSmart app appends 255 to these commands. The first versions (#49, #50) left it out, matching a capture from one car and app build.
Draft: needs a test on a real car
https://claude.ai/code/session_013xKSpu8ev4cxQNsitcCidm