Skip to content

docs: say that the full-open window value differs between models #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanomad merged 1 commit into from
Oct 25, 2026
Merged

docs: say that the full-open window value differs between models #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/saic_ismart_client_ng/api/vehicle/windows/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ class DoorWindowsAction(Enum):
"""What to do with all four door windows at once.

The values are what the iSmart app sends (decrypted MG S6 EV traffic).
Other models may handle 1 and 2 differently; only the MG S6 EV has been
checked. The car reports ventilated and fully open windows the same way in its
status, so the two can't be told apart afterwards.
The value for a full open differs between models and markets:
``control_windows`` sends 3, the MG S6 EV uses 2. Only the MG S6 EV has
been checked. The car reports ventilated and fully open windows the same
way in its status, so the two can't be told apart afterwards.
"""

CLOSE = 0
VENTILATE = 1 # open a few centimetres (only confirmed on the MG S6 EV)
OPEN = 2 # fully open
VENTILATE = 1 # open a few centimetres
OPEN = 2 # fully open (the MG S6 EV value, other models may differ)
Loading