Skip to content

chore: [DevOps] Evaluate beta annotations #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlesDuboisSAP merged 3 commits into from
Aug 25, 2026
Merged

chore: [DevOps] Evaluate beta annotations #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70dac79
methods marked as internal only
Jonas-Isr Aug 21, 2026
966e0e4
handle exception classes
Jonas-Isr Aug 21, 2026
67f8b2a
fix
Jonas-Isr Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/src/main/java/com/sap/ai/sdk/core/JacksonConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import com.fasterxml.jackson.databind.json.JsonMapper;
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
import com.fasterxml.jackson.module.paramnames.ParameterNamesModule;
import com.google.common.annotations.Beta;
import javax.annotation.Nonnull;
import lombok.AccessLevel;
import lombok.NoArgsConstructor;
Expand All @@ -27,7 +26,6 @@ public final class JacksonConfiguration {
* href="https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.html">Jackson2ObjectMapperBuilder</a>
*/
@Nonnull
@Beta
public static JsonMapper getDefaultObjectMapper() {
return JsonMapper.builder()
.addModule(new JavaTimeModule())
Expand Down
3 changes: 3 additions & 0 deletions ...ls/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ public class OpenAiClientException extends ClientException {
/**
* Retrieves the {@link ErrorResponse} from the OpenAI service, if available.
*
* <p>Note: This method is marked as {@link Beta} because it uses generated API types in its
* public signature.
*
* @return The {@link ErrorResponse} object, or {@code null} if not available.
*/
@Beta
Expand Down
6 changes: 6 additions & 0 deletions orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClientException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ public OrchestrationError getClientError() {
/**
* Retrieves the {@link ErrorResponse} from the orchestration service, if available.
*
* <p>Note: This method is marked as {@link Beta} because it uses generated API types in its
* public signature.
*
* @return The {@link ErrorResponse} object, or {@code null} if not available.
* @since 1.10.0
*/
Expand All @@ -134,6 +137,9 @@ public ErrorResponse getErrorResponse() {
/**
* Retrieves the {@link ErrorResponseStreaming} from the orchestration service, if available.
*
* <p>Note: This method is marked as {@link Beta} because it uses generated API types in its
* public signature.
*
* @return The {@link ErrorResponseStreaming} object, or {@code null} if not available.
* @since 1.10.0
*/
Expand Down
2 changes: 0 additions & 2 deletions orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationFilterException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import static com.sap.ai.sdk.orchestration.OrchestrationJacksonConfiguration.getOrchestrationObjectMapper;

import com.google.common.annotations.Beta;
import com.sap.ai.sdk.orchestration.model.AzureContentSafetyInput;
import com.sap.ai.sdk.orchestration.model.AzureContentSafetyOutput;
import com.sap.ai.sdk.orchestration.model.LlamaGuard38b;
Expand All @@ -17,7 +16,6 @@
import lombok.experimental.StandardException;

/** Base exception for errors occurring during orchestration filtering. */
@Beta

@Jonas-Isr Jonas-Isr Aug 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class looks well established by now.

@StandardException(access = AccessLevel.PRIVATE)
public class OrchestrationFilterException extends OrchestrationClientException {

Expand Down
2 changes: 0 additions & 2 deletions ...tration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationJacksonConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.module.SimpleModule;
import com.google.common.annotations.Beta;
import com.sap.ai.sdk.orchestration.model.AzureContentSafetyInput;
import com.sap.ai.sdk.orchestration.model.AzureContentSafetyOutput;
import com.sap.ai.sdk.orchestration.model.ChatMessage;
Expand All @@ -31,7 +30,6 @@ public class OrchestrationJacksonConfiguration {
* href="https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.html">Jackson2ObjectMapperBuilder</a>
*/
@Nonnull
@Beta

@Jonas-Isr Jonas-Isr Aug 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following this comment we just mark the method as "internal only" in the javadoc.

public static ObjectMapper getOrchestrationObjectMapper() {

final var module =
Expand Down