Skip to content

Fix cmake warnings #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hgreenlee wants to merge 11 commits into
base: develop
Choose a base branch
from
+627 −620
Open

Fix cmake warnings #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3a24305
Fix cmake warnings.
hgreenlee Apr 23, 2026
6b84796
Merge remote-tracking branch 'origin/develop' into greenlee_fix_cmake
hgreenlee May 8, 2026
2bb5966
Remove duplicate "PRIVATE."
hgreenlee Jun 25, 2026
7303d77
Merge remote-tracking branch 'origin/develop' into greenlee_fix_cmake
hgreenlee Jun 25, 2026
84def66
Remove duplicate PDMapAlgSimple.cc.
hgreenlee Jun 25, 2026
001314a
v10_21_01
hgreenlee Jun 25, 2026
f81ce40
Merge branch 'main' into greenlee_fix_cmake
hgreenlee Jun 25, 2026
cacc522
Revert cmake updates.
hgreenlee Jun 25, 2026
cd81025
Merge branch 'develop' into greenlee_fix_cmake
hgreenlee Jul 2, 2026
e21a3c0
Add interface library for PDMapAlg.
hgreenlee Jul 2, 2026
a097a22
Update file name comment.
hgreenlee Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sbncode/BeamSpillInfoRetriever/ICARUSBNBEXTRetriever/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

cet_build_plugin(ICARUSBNBEXTRetriever art::module
LIBRARIES
LIBRARIES PRIVATE
art::Persistency_Common
art::Utilities canvas::canvas
cetlib::cetlib cetlib_except::cetlib_except
Expand Down
2 changes: 1 addition & 1 deletion sbncode/BeamSpillInfoRetriever/ICARUSBNBRetriever/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ find_package(ifbeam)
find_package(ifdh_art)

cet_build_plugin(ICARUSBNBRetriever art::module
LIBRARIES
LIBRARIES PRIVATE
sbn_POTTools
sbn_getFOM
SQLite::SQLite3
Expand Down
2 changes: 1 addition & 1 deletion sbncode/BeamSpillInfoRetriever/NuMIEXTRetriever/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

cet_build_plugin(NuMIEXTRetriever art::module
LIBRARIES
LIBRARIES PRIVATE
art::Persistency_Common
art::Utilities canvas::canvas
cetlib::cetlib cetlib_except::cetlib_except
Expand Down
2 changes: 1 addition & 1 deletion sbncode/BeamSpillInfoRetriever/NuMIRetriever/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ find_package(ifbeam)
find_package(ifdh_art)

cet_build_plugin(NuMIRetriever art::module
LIBRARIES
LIBRARIES PRIVATE
art::Persistency_Common
art::Utilities canvas::canvas
cetlib::cetlib cetlib_except::cetlib_except
Expand Down
2 changes: 1 addition & 1 deletion sbncode/BeamSpillInfoRetriever/SBNDBNBEXTRetriever/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ find_package(ifbeam)
find_package(ifdh_art)

cet_build_plugin(SBNDBNBEXTRetriever art::module
LIBRARIES
LIBRARIES PRIVATE
sbn_POTTools
)

Expand Down
2 changes: 1 addition & 1 deletion sbncode/BeamSpillInfoRetriever/SBNDBNBRetriever/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ find_package(ifbeam)
find_package(ifdh_art)

cet_build_plugin(SBNDBNBRetriever art::module
LIBRARIES
LIBRARIES PRIVATE
sbn_POTTools
sbn_getFOM
)
Expand Down
2 changes: 1 addition & 1 deletion sbncode/BeamSpillInfoRetriever/SBNDBNBZEROBIASRetriever/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ find_package(ifbeam)
find_package(ifdh_art)

cet_build_plugin(SBNDBNBZEROBIASRetriever art::module
LIBRARIES
LIBRARIES PRIVATE
sbn_POTTools
sbn_getFOM
)
Expand Down
2 changes: 1 addition & 1 deletion sbncode/CAFMaker/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ art_make_library( LIBRARY_NAME sbncode_CAFMaker
)

cet_build_plugin ( CAFMaker art::module
LIBRARIES
LIBRARIES PRIVATE
sbncode_CAFMaker
sbnanaobj::StandardRecord
larcorealg::Geometry
Expand Down
12 changes: 6 additions & 6 deletions sbncode/Calibration/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

cet_build_plugin( TrackCaloSkimmer art::module
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand Down Expand Up @@ -28,7 +28,7 @@ cet_build_plugin( TrackCaloSkimmer art::module
)

cet_build_plugin(TrackCaloSkimmerSelectStoppingTrack art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -47,7 +47,7 @@ cet_build_plugin(TrackCaloSkimmerSelectStoppingTrack art::tool
)

cet_build_plugin(TrackCaloSkimmerSelectAnode2CathodeTrack art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -61,7 +61,7 @@ cet_build_plugin(TrackCaloSkimmerSelectAnode2CathodeTrack art::tool
)

cet_build_plugin(TrackCaloSkimmerSelectAllTrack art::tool
LIBRARIES
LIBRARIES PRIVATE
sbnobj::Common_Calibration_dict
art::Persistency_Common
art::Utilities canvas::canvas
Expand All @@ -71,7 +71,7 @@ cet_build_plugin(TrackCaloSkimmerSelectAllTrack art::tool
)

cet_build_plugin(TrackCaloSkimmerSelectClearCosmicMuon art::tool
LIBRARIES
LIBRARIES PRIVATE
sbnobj::Common_Calibration_dict
art::Persistency_Common
art::Utilities canvas::canvas
Expand All @@ -81,7 +81,7 @@ cet_build_plugin(TrackCaloSkimmerSelectClearCosmicMuon art::tool
)

cet_build_plugin ( DataSelect art::module
LIBRARIES
LIBRARIES PRIVATE
ifdh_art::IFDH_service
art::Framework_Core
art::Framework_Principal
Expand Down
4 changes: 2 additions & 2 deletions sbncode/Cluster3D/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ set( MODULE_LIBRARIES
art_root_io::TFileService_service
messagefacility::MF_MessageLogger
)
cet_build_plugin(Cluster3DSBN art::module LIBRARIES ${MODULE_LIBRARIES})
cet_build_plugin(SnippetHit3DBuilderSBN art::tool LIBRARIES ${TOOL_LIBRARIES} SOURCE SnippetHit3DBuilderSBN_tool.cc)
cet_build_plugin(Cluster3DSBN art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})
cet_build_plugin(SnippetHit3DBuilderSBN art::tool LIBRARIES PRIVATE ${TOOL_LIBRARIES})
set_property(SOURCE SnippetHit3DBuilderSBN_tool.cc APPEND PROPERTY COMPILE_DEFINITIONS EIGEN_FFTW_DEFAULT)

install_headers()
Expand Down
2 changes: 1 addition & 1 deletion sbncode/CosmicID/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cet_build_plugin( CRUMBS art::module
LIBRARIES
LIBRARIES PRIVATE
art_root_io::TFileService_service
fhiclcpp::fhiclcpp
art::Persistency_Provenance canvas::canvas
Expand Down
4 changes: 2 additions & 2 deletions sbncode/DetSim/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ set( MODULE_LIBRARIES
FFTW3::FFTW3
)

cet_build_plugin(AdjustSimForTrigger art::module LIBRARIES ${MODULE_LIBRARIES})
cet_build_plugin(FilterSimEnergyDeposits art::module LIBRARIES ${MODULE_LIBRARIES})
cet_build_plugin(AdjustSimForTrigger art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})
cet_build_plugin(FilterSimEnergyDeposits art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})

add_subdirectory(fcl)

Expand Down
4 changes: 2 additions & 2 deletions sbncode/EventGenerator/MeVPrtl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ add_subdirectory(Tools)
add_subdirectory(config)

cet_build_plugin( MeVPrtlGen art::module
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -24,7 +24,7 @@ cet_build_plugin( MeVPrtlGen art::module
)

cet_build_plugin( MeVPrtlTestRayTrace art::module
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand Down
4 changes: 2 additions & 2 deletions sbncode/EventGenerator/MeVPrtl/Tools/ALP/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ art_make_library( LIBRARY_NAME sbncode_EventGenerator_MeVPrtl_ALP_ThreeBodyInteg
)

cet_build_plugin( Meson2ALP art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -25,7 +25,7 @@ cet_build_plugin( Meson2ALP art::tool
)

cet_build_plugin( ALPMakeDecay art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand Down
17 changes: 8 additions & 9 deletions sbncode/EventGenerator/MeVPrtl/Tools/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ art_make_library( LIBRARY_NAME sbncode_EventGenerator_MeVPrtl_Constants


cet_build_plugin( EmptyKaonGen art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -34,7 +34,7 @@ cet_build_plugin( EmptyKaonGen art::tool


cet_build_plugin( NuMiKaonGen art::tool
LIBRARIES
LIBRARIES PRIVATE
ifdh_art::IFDH_service
art::Framework_Core
art::Framework_Services_Registry
Expand All @@ -57,7 +57,7 @@ cet_build_plugin( NuMiKaonGen art::tool
)

cet_build_plugin( TxtFileGen art::tool
LIBRARIES
LIBRARIES PRIVATE
ifdh_art::IFDH_service
art::Framework_Core
art::Framework_Services_Registry
Expand All @@ -80,8 +80,7 @@ cet_build_plugin( TxtFileGen art::tool
)

cet_build_plugin( BNBKaonGen art::tool

LIBRARIES
LIBRARIES PRIVATE
ifdh_art::IFDH_service
art::Framework_Core
art::Framework_Services_Registry
Expand All @@ -104,7 +103,7 @@ cet_build_plugin( BNBKaonGen art::tool
)

cet_build_plugin( WeightedRayTraceBox art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -127,7 +126,7 @@ cet_build_plugin( WeightedRayTraceBox art::tool
)

cet_build_plugin( MixedWeightRayTraceBox art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -153,7 +152,7 @@ cet_build_plugin( MixedWeightRayTraceBox art::tool


cet_build_plugin( ReThrowRayTraceBox art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -175,7 +174,7 @@ cet_build_plugin( ReThrowRayTraceBox art::tool
)

cet_build_plugin( RayTraceBox art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand Down
6 changes: 3 additions & 3 deletions sbncode/EventGenerator/MeVPrtl/Tools/HNL/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ art_make_library( LIBRARY_NAME sbncode_EventGenerator_MeVPrtl_AnTwoBD


cet_build_plugin( Kaon2HNLFlux art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -65,7 +65,7 @@ cet_build_plugin( Kaon2HNLFlux art::tool
)

cet_build_plugin( Tau2HNLFlux art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -86,7 +86,7 @@ cet_build_plugin( Tau2HNLFlux art::tool
)

cet_build_plugin( HNLMakeDecay art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand Down
6 changes: 3 additions & 3 deletions sbncode/EventGenerator/MeVPrtl/Tools/Higgs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cet_build_plugin( MonoEnergyHiggsFlux art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -17,7 +17,7 @@ cet_build_plugin( MonoEnergyHiggsFlux art::tool


cet_build_plugin( Kaon2HiggsFlux art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand All @@ -37,7 +37,7 @@ cet_build_plugin( Kaon2HiggsFlux art::tool
)

cet_build_plugin( HiggsMakeDecay art::tool
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Services_Registry
art_root_io::TFileService_service
Expand Down
2 changes: 1 addition & 1 deletion sbncode/EventGenerator/WireModGen/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cet_build_plugin(WireModMuon art::EDProducer
SOURCE CORSIKAGenSBN.cc WireModMuon_module.cc
REG_SOURCE CORSIKAGenSBN.cc WireModMuon_module.cc
Comment thread
PetrilloAtWork marked this conversation as resolved.
LIBRARIES PRIVATE
larcore::Geometry_Geometry_service
larcorealg::Geometry
Expand Down
2 changes: 1 addition & 1 deletion sbncode/FlashMatch/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ set( MODULE_LIBRARIES
ROOT::Gdml
)

cet_build_plugin(FlashPredict art::module LIBRARIES ${MODULE_LIBRARIES})
cet_build_plugin(FlashPredict art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})


install_headers()
Expand Down
6 changes: 3 additions & 3 deletions sbncode/FluxReader/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ cet_enable_asserts()
file(GLOB INTERFACEFILES *Interface* )

cet_build_plugin( FluxReader art::source
LIBRARIES
LIBRARIES PRIVATE
sbncode_FluxReader
larcore::Geometry_Geometry_service
nutools::EventGeneratorBase_CRY
lardata::Utilities
)

cet_build_plugin ( FluxGeoFilter art::module
LIBRARIES
LIBRARIES PRIVATE
art::Framework_Core
art::Framework_Principal
art::Framework_Services_Registry
Expand Down Expand Up @@ -71,7 +71,7 @@ cet_make_library(
lardata::Utilities
)

cet_build_plugin(FluxReaderAna art::module LIBRARIES
cet_build_plugin(FluxReaderAna art::module LIBRARIES PRIVATE
sbncode_FluxReader
sbncode_FluxReader_FluxInterface
nusimdata::SimulationBase
Expand Down
6 changes: 3 additions & 3 deletions sbncode/HitFinder/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ set( MODULE_LIBRARIES

)
cet_build_plugin(GaussHitFinderSBN art::module
LIBRARIES ${MODULE_LIBRARIES}
LIBRARIES PRIVATE ${MODULE_LIBRARIES}
larreco::HitFinder
larreco::CandidateHitFinderTool
larreco::PeakFitterTool
)
cet_build_plugin(ChannelROIToWire art::module LIBRARIES ${MODULE_LIBRARIES})
cet_build_plugin(WireToChannelROI art::module LIBRARIES ${MODULE_LIBRARIES})
cet_build_plugin(ChannelROIToWire art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})
cet_build_plugin(WireToChannelROI art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})


install_headers()
Expand Down
4 changes: 2 additions & 2 deletions sbncode/LArG4/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ set(
sbncode_LArG4_PhysicsLists
)

cet_build_plugin(PhysListLoader art::module SOURCE PhysListLoader_module.cc LIBRARIES ${MODULE_LIBRARIES})
cet_build_plugin(PhysListLoader art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})

cet_make_library(SOURCE MergeSimSourcesLiteUtility.cxx
LIBRARIES
Expand All @@ -35,7 +35,7 @@ cet_make_library(SOURCE MergeSimSourcesLiteUtility.cxx
)

cet_build_plugin(MergeSimSourcesSBN art::EDProducer
LIBRARIES
LIBRARIES PRIVATE
sbncode::LArG4
larsim::MergeSimSources
lardataobj::MCBase
Expand Down
Loading