Repository navigation
Fix shared boundary fan artifacts with multiple boundary loops (#2610) - #2671
Merged
Merged
Conversation
snap_boundary_to_mesh snapped whichever boundary loop libigl returned first, so a pre-existing loop (e.g. a cropped shaft) could be dragged onto the shared boundary. Snap only the seam vertices left by removing the shared surface, against all loops of the shared surface. extract_boundary_loop now picks the longest loop instead of an arbitrary one. Adds regression tests for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2610
snap_boundary_to_mesh snapped whichever boundary loop libigl returned first, so a pre-existing loop (e.g. a cropped shaft) could be dragged onto the shared boundary. Snap only the seam vertices left by removing the shared surface, against all loops of the shared surface.
extract_boundary_loop now picks the longest loop instead of an arbitrary one. Adds regression tests for both.