Repository navigation
Conversation
The interface can now run in English, French or Portuguese. Language starts from the browser, and there is a sidebar picker if you want to change it. French stays as it is today. Missing translations fall back to French. The choice is saved only after you pick one. Co-authored-by: Cursor <cursoragent@cursor.com>
This builds on the previous commit. Notifications can now be multilingual as well, and the language is set on each channel. Existing channels stay on French with the same wording as before. You can still override the subject and body; if those fields are empty, the default text for that language is used. Co-authored-by: Cursor <cursoragent@cursor.com>
Adds frontend and backend tests so later changes are easier to make without breaking language or notification behaviour. The READMEs mention how to run them. GitHub Actions runs both suites on push and pull request. Co-authored-by: Cursor <cursoragent@cursor.com>
… the full blob Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
P.S.: Sorry for the massive diff, but I figured that since I'm running this version, might as well contribute back. It's MUCH smaller than it looks though (a lot of that are the translation strings and adding them in the right places)! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This admittedly completely vibe-coded PR handles:
As part of this change, notification channels get a language field (default
fr) and optional subject/body overrides. The "live" preview uses the same builder as a real send (POST /api/notifications/preview).As for the log viewer, the run detail no longer ships the entire
log_outputblob. Instead,GET /api/runs/{id}/logsreturns a window, and the viewer jumps to start/end and loads/unloads chunks as you scroll so a huge log does not sit in memory. List/detail exposelog_bytesinstead.I can't 100% confirm that the french texts were not changed during the introduction of localization, but I whipped my best whip with cursor to make sure they didn't.
Test plan (as written entirely by an LLM, and expected to be as useful they are as elbow replacements)