♻️ refactor(SurfPlayerRepository): enhance player retrieval logic wit… - #65
Merged
Merged
Conversation
…h case-insensitive search and ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the player name lookup logic and bumps the project version. The main change improves how players are searched by name, making the query case-insensitive and ensuring the most recently seen player is returned if there are duplicates.
Database query improvements:
loadPlayerByNamemethod inSurfPlayerRepositorynow performs a case-insensitive search by usinglowerCase()on both the column and input, and orders results bylastSeen(most recent first), returning the most recently seen matching player.SortOrderandlowerCaseto support the improved query.Version update:
2.5.3to2.5.4ingradle.properties.