Skip to content

Let user specify the events considered when generating SightNoDaily #7

Description

@smwoodman

das_sight currently always uses all of the S/K/M/G events to generate SightNoDaily values. This is regardless of return.events arguments.

The function should be updated to provide some way for the user to specify the events considered when generating SightNoDaily values. Probably simplest/most consistent to use return.events.

Related, because of this, das_sight currently inefficiently always processes all sighing information, rather than filtering based on return.events early. Explore ways to filter earlier to minimize processing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions