Repository navigation
chore: design-tokens 자동 반영 - #46
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
제공된 diff에서 실제 코드 변경은 없으며, |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d7e74febe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| static var basicBlack: Color { .init(hex: "1A1A1A") } | ||
| static var errorAlpha: Color { .init(hex: "C92D33", alpha: 0.4) } | ||
| static var errorDefault: Color { .init(hex: "C92D33") } |
There was a problem hiding this comment.
Preserve errorStrong until its caller is migrated
When compiling PickeDesignKit, FloatingErrorView.swift:30 still passes .errorStrong to roundedBackground, but this change removes the only definition of that ShapeStyle member; a repository-wide search found no replacement definition. The design-kit target, and consequently the app, will fail to build until the compatibility token is retained or the caller is migrated in the same commit.
Useful? React with 👍 / 👎.
자동 생성된 디자인 토큰 반영
Source:
SWYP-Find/design-tokens@11f3dc51339834a29ade9bf8fb5afc0d5d750469Trigger:
pushonmainWorkflow run: #13
Branch:
chore/design-tokens-sync-20261002-114128→develop두 단계 검증 통과
$type/ alias 정합성)Tools/TokenGenerator.swift실행 (실제 사용 Swift 코드 생성)변경된 파일
Projects/Shared/DesignSystem/Sources/Color/ShapeStyle+.swiftProjects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Radius+.swiftProjects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Spacing+.swiftProjects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Component+.swiftProjects/Shared/DesignSystem/Sources/UI/Token/ComponentToken.swift