Skip to content

chore: design-tokens 자동 반영 - #46

Merged
Roy-wonji merged 1 commit into
developfrom
chore/design-tokens-sync-20261002-114128
Oct 2, 2026
Merged

Roy-wonji merged 1 commit into
developfrom
chore/design-tokens-sync-20261002-114128

Conversation

@Roy-wonji

Copy link
Copy Markdown
Contributor

자동 생성된 디자인 토큰 반영

Source: SWYP-Find/design-tokens@11f3dc51339834a29ade9bf8fb5afc0d5d750469
Trigger: push on main
Workflow run: #13
Branch: chore/design-tokens-sync-20261002-114128 → develop

두 단계 검증 통과

  • 1차: Style Dictionary v4 빌드 (DTCG $type / alias 정합성)
  • 2차: Tools/TokenGenerator.swift 실행 (실제 사용 Swift 코드 생성)

변경된 파일

  • Projects/Shared/DesignSystem/Sources/Color/ShapeStyle+.swift
  • Projects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Radius+.swift
  • Projects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Spacing+.swift
  • Projects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Component+.swift
  • Projects/Shared/DesignSystem/Sources/UI/Token/ComponentToken.swift

토큰 JSON 원본은 design-tokens 리포에만 보관되며, generator 가 빌드 시점에 TOKENS_SOURCE_DIR 로 직접 읽습니다. ios-repo Resources 에는 더 이상 복사되지 않습니다.

자동 생성된 PR. 토큰 변경 시마다 새 브랜치/새 PR 이 생성되며, 머지 시 브랜치는 자동 삭제됩니다.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T11:43:29.631715Z 7d7e74f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

제공된 diff에서 실제 코드 변경은 없으며, MARK: 주석 앞의 빈 줄을 제거하는 등 포맷 변경만 이루어졌습니다. P5 nitpick (빈 줄, 공백, 주석 등)에 대한 코멘트는 규칙에 따라 제외합니다.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d7e74febe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


static var basicBlack: Color { .init(hex: "1A1A1A") }
static var errorAlpha: Color { .init(hex: "C92D33", alpha: 0.4) }
static var errorDefault: Color { .init(hex: "C92D33") }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve errorStrong until its caller is migrated

When compiling PickeDesignKit, FloatingErrorView.swift:30 still passes .errorStrong to roundedBackground, but this change removes the only definition of that ShapeStyle member; a repository-wide search found no replacement definition. The design-kit target, and consequently the app, will fail to build until the compatibility token is retained or the caller is migrated in the same commit.

Useful? React with 👍 / 👎.

@Roy-wonji
Roy-wonji merged commit 14eceb9 into develop Oct 2, 2026
5 checks passed
@Roy-wonji
Roy-wonji deleted the chore/design-tokens-sync-20261002-114128 branch October 2, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants