Fix/new shader issues - #6
Open
cheese3660 wants to merge 5 commits into
Open
Conversation
Fix _USE_PQS_BUFFER keyword not seen by unity in CelestialBody_Local_Overlay
VisibleQuadMeshIndices was declared Buffer<uint>, which compiles to a typed fetch and needs an SRV carrying a real DXGI format. The buffer bound to it is PQSRenderer's culled index buffer, allocated with ComputeBufferType.Default and so viewed as a structured buffer with DXGI_FORMAT_UNKNOWN. A typed load against a format-less view is undefined in D3D11. At stride 4 a structured descriptor is bit-compatible with R32_UINT, so the mismatch is invisible on NVIDIA and AMD; drivers that encode typed surfaces separately take every load out of bounds and read back zero, collapsing the overlay geometry onto a single quad. The same declaration in the SDK's terrain and overlay shaders is corrected in KSP2Redux/SDK#fix/new-shader-issues.
Author
|
wait wrong repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.