[deep-sengupta]

Problem

main() previously constructed Benchmark() before checking whether the supplied scanner name was supported. This could trigger unnecessary dataset preparation for invalid input. The manual error branch also returned normally, resulting in a successful exit status for invalid scanner names.

Additionally, nargs="?" allowed --scanner to be supplied without a value.

Changes

• Add choices=SCANNER_LIST to the --scanner argument.
• Remove nargs="?" so the scanner value is required.
• Remove the redundant manual scanner validation.
• Add regression tests for an unknown scanner name and a missing scanner value, verifying that Benchmark is not initialized.

Testing

• New regression tests pass.
• Existing unit tests pass.
• python -m benchmark -h displays the required scanner argument.
• Invalid scanner input exits with status 2 before benchmark initialization.

No full benchmark run was performed because this change only affects argument validation.

[babenek]

Good point!
please update

def get_arguments() -> Namespace:

to

def get_arguments(argv:list[str]) -> Namespace:

and parse incoming arguments

also in main

def main(argv) -> None:
    args = get_arguments(argv[1:])

if __name__ == """__main__""":
    sys.exit(main(sys.argv))

then avoid extra patching in tests

[deep-sengupta]

Thanks for the feedback! I've made the requested changes and verified that all 9 tests pass.

[babenek]

LGTM

[babenek]

Mocking should be a last resort. Prefer real objects and test units directly by default, without invoking their parent functions just to reach them.
Function main() is easy byself.
Test only get_arguments() instead:

1. test with unsupported scanner
2. test with supported scanner (credsweeper ;)
   no auxiliary methods required!

[babenek]

Code - OK
Test - rewrite

[deep-sengupta]

Thanks for the feedback! I've rewritten the tests to call get_arguments() directly, without mocking or auxiliary methods. The tests now cover both unsupported and supported scanner values.

[babenek]

LGTM. Thanks @deep-sengupta

[Pomidorry]