Repository navigation
Fix benchmark handling for scanners without rule names - #356
Open
deep-sengupta wants to merge 2 commits into
Open
deep-sengupta wants to merge 2 commits into
deep-sengupta wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Some scanner adapters pass a file path and line number to
check_line_from_meta()without providing a rule name. The method can attempt to create aMetaRowwith an emptyCategory, which may raise aValueError.Solution
Handle rule-less detections explicitly and defer metadata-row creation until it is needed. Keep metadata validation unchanged, define consistent matching and counting behavior for findings without rule names, and use a non-empty fallback category when saving new metadata in fix mode.
Testing
git diff --checkpasses.