Skip to content

⚡ Optimize useSound detune loop #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sanan507 merged 1 commit into from
Sep 11, 2026
Merged

⚡ Optimize useSound detune loop #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/hooks/useSound.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,13 @@ function playChord(
// Exponential decay to simulate vibraphone resonance
gainNode.gain.exponentialRampToValueAtTime(0.0001, startTime + durationSec);

for (const note of chord.notes) {
for (let i = 0; i < chord.notes.length; i++) {
const note = chord.notes[i];
const osc = ctx.createOscillator();
osc.type = chord.type;
osc.frequency.setValueAtTime(midiToHz(note), startTime);
// Slight detune per note for vibraphone width
osc.detune.setValueAtTime((chord.notes.indexOf(note) - 1) * 2, startTime);
osc.detune.setValueAtTime((i - 1) * 2, startTime);
osc.connect(gainNode);
osc.start(startTime);
osc.stop(startTime + durationSec + 0.05);
Expand Down
Loading