Skip to content

🔒 Fix integer overflow in binary search and merge sort midpoint calculations - #134

Merged
Sanan507 merged 1 commit into
masterfrom
jules/fix-binary-search-overflow-14758088103233515261
Sep 11, 2026
Merged

Sanan507 merged 1 commit into
masterfrom
jules/fix-binary-search-overflow-14758088103233515261

Conversation

@Sanan507

Copy link
Copy Markdown
Owner

This PR fixes an integer overflow vulnerability in binary search and merge sort midpoint calculations by changing (low + high) / 2 to low + (high - low) / 2 (or the equivalent Math.floor in TypeScript).

This prevents integer overflow issues when the array size is very large.

Changes made:

  • Updated frontend/src/data/gymChallenges.ts to use the correct calculation.
  • Fixed the binarysearch snippet in frontend/src/data/algorithmCodeSnippets.ts.
  • Fixed the binarySearch and mergeSort calculation in frontend/src/workers/simulationWorker.ts.
  • Fixed the buildOps midpoint calculation in backend/src/main/java/com/algorithmrace/visualizer/algorithms/sorting/MergeSortModel.java.

All frontend and backend unit tests pass.


PR created automatically by Jules for task 14758088103233515261 started by @Sanan507

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
algorithm-race-visualizer Ready Ready Preview Sep 11, 2026 3:48pm UTC

@Sanan507
Sanan507 merged commit 28da8f1 into master Sep 11, 2026
4 checks passed
@Sanan507
Sanan507 deleted the jules/fix-binary-search-overflow-14758088103233515261 branch September 15, 2026 09:30

This branch was successfully deployed

1 active deployment
Preview cc8edccb Deployed Sep 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant