🔒 Fix integer overflow in binary search and merge sort midpoint calculations - #134
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This PR fixes an integer overflow vulnerability in binary search and merge sort midpoint calculations by changing
(low + high) / 2tolow + (high - low) / 2(or the equivalentMath.floorin TypeScript).This prevents integer overflow issues when the array size is very large.
Changes made:
frontend/src/data/gymChallenges.tsto use the correct calculation.binarysearchsnippet infrontend/src/data/algorithmCodeSnippets.ts.binarySearchandmergeSortcalculation infrontend/src/workers/simulationWorker.ts.buildOpsmidpoint calculation inbackend/src/main/java/com/algorithmrace/visualizer/algorithms/sorting/MergeSortModel.java.All frontend and backend unit tests pass.
PR created automatically by Jules for task 14758088103233515261 started by @Sanan507