feat: return expiration from getCredentials - #67
Draft
nicomiguelino wants to merge 2 commits into
Draft
Conversation
- Add expiration field to getCredentials() return type and destructure it from the token endpoint response - Update JSDoc to document the new optional/nullable expiration field - Add oauth.test.ts covering token+expiration, null/missing expiration, and metadata behavior
- Bump package.json/package-lock.json version from 1.3.0 to 1.4.0 - Shared with sibling PR #68 since it is unclear which of the two additive, backward-compatible changes will merge first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCredentials()insrc/utils/oauth.tsnow also returnsexpirationfrom the token endpoint's JSON response (string | null | undefined), alongsidetokenandmetadata.src/utils/oauth.test.tscovering: token+expiration present,expirationnull,expirationmissing, and existingmetadatabehavior.Out of scope (flagging as possible follow-ups, not implemented here):
initTokenRefreshLoop()is intentionally untouched — a separate PR is making it expiration-aware.response.okerror handling was added togetCredentials().