Skip to content

chore: clear test leftovers and unused deps #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ScriptedAlchemy wants to merge 3 commits into from
Closed

chore: clear test leftovers and unused deps #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bf0d44
refactor(hooks): inline the test-only route-metadata wrapper
ScriptedAlchemy Aug 24, 2026
ffca362
chore(deps): clear new cargo-shear findings
ScriptedAlchemy Aug 24, 2026
cd36428
Merge remote-tracking branch 'origin/codex/tracedecay-total-redesign-…
ScriptedAlchemy Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,6 @@ tracedecay-code-extraction = { path = "crates/tracedecay-code-extraction", versi
tracedecay-code-index = { path = "crates/tracedecay-code-index", version = "0.1.0", default-features = false }
tracedecay-dashboard-api = { path = "crates/tracedecay-dashboard-api", version = "0.1.0" }
tracedecay-domain = { path = "crates/tracedecay-domain", version = "0.1.0" }
tracedecay-host-integration = { path = "crates/tracedecay-host-integration", version = "0.1.0" }
tracedecay-hooks = { path = "crates/tracedecay-hooks", version = "0.1.0" }
tracedecay-jsonrpc = { path = "crates/tracedecay-jsonrpc", version = "0.1.0" }
tracedecay-lsp = { path = "crates/tracedecay-lsp", version = "0.1.0" }
Expand Down Expand Up @@ -436,7 +435,6 @@ crossterm = "0.28"
fs2 = "0.4"
same-file = "1"
sysinfo = { version = "0.32", default-features = false, features = ["system"] }
open = "5.3"
# Raw filesystem watcher for the daemon git-metadata watcher (src/daemon/git_watch.rs).
# We deliberately use the raw watcher (not notify-debouncer-full) and debounce
# ourselves so a monorepo's git-ref churn coalesces into a single sync.
Expand All @@ -457,9 +455,6 @@ tokio-rustls = { version = "0.26", default-features = false, features = ["ring",
flate2 = "1"
tar = "0.4"

[target.'cfg(target_os = "linux")'.dev-dependencies]
xattr = "1"

# `statfs(2)` for daemon store-locality detection (src/daemon/store_runtime/
# resolver.rs). Linux reads `/proc/self/mountinfo` instead; macOS has no such
# file, and `MNT_LOCAL` is the kernel's direct answer to "is this volume local".
Expand Down
1 change: 0 additions & 1 deletion crates/tracedecay-agent-hosts/src/hooks/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,6 @@ fn take_test_daemon_hook_action(
)
}

// Only the hook tests assert on the derived route metadata.
pub(crate) fn hook_route_metadata_from_parsed(
parsed: &Value,
project_root: &Path,
Expand Down
11 changes: 8 additions & 3 deletions crates/tracedecay-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,7 @@ url = "2"
[dev-dependencies]
axum = "0.8"
dirs = "6"
filetime = "0.2"
fs2 = "0.4"
jsonschema = { version = "0.46.8", default-features = false }
regex = "1.12.3"
tempfile = "3"

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore regex for default CLI test builds

When CLI unit tests run with the default production feature rather than --all-features, cfg(test) compiles hotpath_focus_is_valid, which calls regex::Regex::new, but the remaining normal regex dependency is optional and activated only by hotpath. Removing this dev-dependency therefore makes cargo test -p tracedecay-cli fail with an unresolved regex crate; retain the test dependency or ensure the test build activates it.

AGENTS.md reference: AGENTS.md:L33-L34

Useful? React with 👍 / 👎.

tokio = { version = "1", features = ["full", "test-util"] }
toml = "1"
Expand All @@ -134,5 +131,13 @@ xattr = "1"
[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ["cfg(tracedecay_observation_fault_harness)"] }

# `fs2` is consumed only by `tests/common/fixture.rs` (shared at the repo
# root and pulled into this crate's integration test binaries via a
# relative `#[path]`, not by any file under this crate's own directory
# tree), so cargo-shear's per-crate scan cannot see the use and reports a
# false positive.
[package.metadata.cargo-shear]
ignored = ["fs2"]

[build-dependencies]
logo-art = "0.2"
1 change: 0 additions & 1 deletion crates/tracedecay-search-eval/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,4 @@ tracedecay-search-eval = { path = ".", features = ["evaluator-corpus-languages"]
# The self dev-dependency enables corpus language tiers for this crate's own
# tests; assets/ holds checked-in eval fixture corpora, not crate sources.
[package.metadata.cargo-shear]
ignored = ["tracedecay-search-eval"]
ignored-paths = ["assets/**"]
Loading