fix(index): stop one bad file from blocking a whole index - #716
fix(index): stop one bad file from blocking a whole index#716ScriptedAlchemy wants to merge 4 commits into
Conversation
A real repository could never finish indexing: an empty-string test.describe suite name in react-router hit a debug_assert in generate_node_id, panicked the index worker, and the scheduler retried the same unit 114 times. The assert also compiled out in release, so release builds silently minted a node id for an empty name instead — the two profiles disagreed on the same input. Source text is input, not a programmer-contract violation, so generate_node_id no longer asserts on it, and a panicking reconcile unit is now isolated rather than poisoning the generation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…plan-reopened' into HEAD
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c1599f5cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mod privacy; | ||
| pub(in crate::daemon) mod queries; | ||
| pub(in crate::daemon) mod query_runtime; | ||
| mod reconcile_panic_guard; |
There was a problem hiding this comment.
When another arbitrary-source reconcile panic occurs, this declaration is the guard's only production reference: the worker in registry.rs still handles the panicked spawn_blocking task as a generic JoinError, restores the pending arrival, and never calls record_panic/suppresses_pass or schedules RetryAfter. Later wakes therefore retry the same bad input without the advertised backoff or quarantine; instantiate the guard in that worker or omit this dead feature.
AGENTS.md reference: AGENTS.md:L105-L107
Useful? React with 👍 / 👎.
|
Closing as incomplete and superseded. Its panic guard is not wired into the worker. The valid minimal empty-name identity behavior and focused tests were selectively applied for PR 707; none of the dead panic machinery was taken. |
1 participant
Reopened against
codex/tracedecay-total-redesign-plan-reopened. Note: an earlier version of this was reverted as "ineffective panic quarantine" and that criticism was correct — the guard was declared but never reached from the worker. Seeclaude/panic-guard-wiring(the follow-up) for the actual wiring. This branch carries the bad-file half only. Close it if the base already covers that.