fix(clippy): clear the workspace clippy failures on #707

[ScriptedAlchemy]

What this fixes

Clippy has been failing on #707 continuously — it failed on e2430e639, was not re-attempted while the light 8-check gate ran, and reproduced identically when the wide run fanned out again on fac184df5. Roughly ten commits landed in between without it being addressed, because the intervening runs never executed it.

Reproduced locally with the exact CI command (cargo clippy --workspace --all-targets --locked -- -D warnings) in an isolated worktree, so nothing touched the shared checkout's in-progress files.

The one that needed a judgement call

publish_verified_inner was at 8 arguments (7 allowed), with three of them a manifest option plus two adjacent bools. Rather than raise the threshold or #[allow] it, the three mode choices are grouped into GraphPublishModeV1. That also fixes the readability problem the lint is pointing at: ..., false, true) at a call site said nothing about which knob was which, and the four call sites now name each field.

The rest

site	lint
writer/worker/mod.rs	field reassign after Default::default() (the WAL-budget test)
codex/tests.rs ×2	same, on CodexReplayIndex
lcm/gc/tests.rs ×2	redundant clone() to build a slice — uses slice::from_ref
lcm/query.rs	redundant deref
session_temporal/projection/tests.rs	drop() on a type with no Drop impl
database_owner_registry.rs	complex return type named; .iter().map(|(k,_)|…) → .keys()
code_index_scheduler/tests.rs	collapsible nested if
dashboard.rs ×2	needless explicit lifetimes
bootstrap.rs, invocation_state.rs	doc identifiers missing backticks
session_temporal_refresh_scheduler/worker.rs	from_secs(60) → from_mins(1)

No #[allow] was added anywhere.

Verification

cargo clippy --workspace --all-targets --locked -- -D warnings — clean.

Note: Hawk, Dashboard and Build Windows tests also fail on the same wide run and are not addressed here. They are separate failures needing their own fixes.

🤖 Generated with Claude Code

[changeset-bot]

⚠️ No Changeset found

Latest commit: afd5ef3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR