Skip to content

fix(ci): unbreak Hawk and match its documented advisory intent #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 3 commits into from
Aug 24, 2026
Merged

fix(ci): unbreak Hawk and match its documented advisory intent #720

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6fe3eb
fix(ci): unbreak Hawk and match its documented advisory intent
ScriptedAlchemy Aug 24, 2026
207ffcc
Merge remote-tracking branch 'origin/codex/tracedecay-total-redesign-…
ScriptedAlchemy Aug 24, 2026
7afbd13
chore: drop the duplicate gated Value import
ScriptedAlchemy Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,13 @@ jobs:
printf '%s\n' '<!doctype html><title>hawk</title>' > dashboard/app-dist/index.html

- name: Hawk
# Reports, does not gate. The job header above states Hawk is not a
# required check until the workspace is clean under `-D warnings`, but
# the step hard-failed anyway, so Hawk showed as a red required check
# while the workspace carries ~9k visibility findings. Keep `-D
# warnings` so the report stays honest, and drop the gate until the
# backlog is burned down and this line can be removed.
continue-on-error: true

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Hawk execution failures visible

When the Hawk invocation fails for a reason other than the known visibility findings—for example, an all-feature target stops compiling or Hawk crashes—continue-on-error: true also turns that failure into a successful job, so CI can go green without producing the advisory report at all. The compile failure fixed by this same commit is exactly such a scenario. Make findings non-blocking without accepting every failure from the command, such as by avoiding promotion of warnings to an error exit or distinguishing Hawk's findings exit code.

AGENTS.md reference: AGENTS.md:L126-L128

Useful? React with 👍 / 👎.

run: cargo +1.97.1 hawk check --target-dir target/hawk -D warnings

fmt:
Expand Down
Loading