Skip to content

Use consistent implementation for Node::peephole() - #255

Merged
cliffclick merged 1 commit into
SeaOfNodes:mainfrom
fuhsnn:ch4-peephole-impl
Sep 27, 2026
Merged

cliffclick merged 1 commit into
SeaOfNodes:mainfrom
fuhsnn:ch4-peephole-impl

Conversation

@fuhsnn

@fuhsnn fuhsnn commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

The logic is same but only ch4 has this version.

if( obs != null ) obs.after(this, n == null && old == _type ? null : rez, false);

if( obs != null ) obs.after(this, n != null || old != _type ? rez : null, false);

if( obs != null ) obs.after(this, n == null && old == _type ? null : rez, false);

@cliffclick cliffclick left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cliffclick
cliffclick merged commit 837b6ae into SeaOfNodes:main Sep 27, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants