feat(inference): show vendor-aware precision in legend and tooltip#472
feat(inference): show vendor-aware precision in legend and tooltip#472Oseltamivir wants to merge 2 commits into
Conversation
…and tooltip Legend entries now display precision after a · separator (e.g. "B300 (vLLM) · NVFP4", "MI355X (vLLM) · FP8"). FP4 is mapped to NVFP4 (NVIDIA) / MXFP4 (AMD) based on the GPU's vendor in HW_REGISTRY; FP8 stays generic since the DB doesn't distinguish E4M3 vs MXFP8. Multi-precision SKUs join with / (e.g. "· NVFP4 / FP8"). - Add getPrecisionDisplayLabel(precision, hwKey) to lib/constants.ts - Update official + overlay legend labels in ScatterGraph.tsx - Route line labels (lineLabelText, overlayLabelText) through vendor format - Add precision line to ChartTooltip - Add unit tests for the new helper
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <p>{`GPU: ${hardwareConfig[pointPayload.hwKey as keyof typeof hardwareConfig].gpu}`}</p> | ||
| {pointPayload.precision && ( | ||
| <p>{`Precision: ${getPrecisionDisplayLabel(pointPayload.precision, String(pointPayload.hwKey ?? ''))}`}</p> | ||
| )} |
There was a problem hiding this comment.
Scatter tooltip still generic precision
Medium Severity
Vendor-aware precision was added in ChartTooltip, but the inference scatter chart does not render that component. Hovers still use generateTooltipContent, which uppercases the raw precision field, so legend entries can show labels like NVFP4 while the hover line still shows FP4 or FP4FP8.
Reviewed by Cursor Bugbot for commit 8c0d233. Configure here.
| (PRECISION_OPTIONS as readonly string[]).indexOf(b), | ||
| ) | ||
| .map((p) => getPrecisionDisplayLabel(p, sampleHwKey)) | ||
| .join(' / ')}`; |
There was a problem hiding this comment.
Overlay legend wrong vendor label
Low Severity
Unofficial-run legend precision suffixes call getPrecisionDisplayLabel with a single sampleHwKey taken from the first matching overlay point. If one run includes multiple hardware keys, fp4/fp4fp8 labels for every precision use that one vendor, which can mislabel NVIDIA data as MXFP4 or the reverse.
Reviewed by Cursor Bugbot for commit 8c0d233. Configure here.
|
Found 2 test failures on Blacksmith runners: Failures
|
precisionsPerHw was derived from filteredData (which excludes inactive hw types), so toggled-off SKUs lost their precision suffix. Derive from all data points filtered only by selectedPrecisions instead.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 792177c. Configure here.
| : ''; | ||
| return { | ||
| name: hwConfig.name, | ||
| label: `${baseLabel}${precSuffix}`, |
There was a problem hiding this comment.
Hover tooltip precision not vendor-aware
Medium Severity
This commit adds vendor-aware precision suffixes to chart legend labels via getPrecisionDisplayLabel, but the inference scatter chart still builds hover tooltips through generateTooltipContent, which shows d.precision.toUpperCase() (e.g. FP4). Legend and point tooltip can disagree on the same chart after this change.
Reviewed by Cursor Bugbot for commit 792177c. Configure here.
1 participant
Summary
·separator — e.g.B300 (vLLM) · NVFP4,MI355X (vLLM) · FP8HW_REGISTRYvendor; FP8 stays generic (DB doesn't distinguish E4M3 vs MXFP8)/— e.g.B200 (vLLM) · NVFP4 / FP8Precision:line?unofficialrun=overlaysTest plan
getPrecisionDisplayLabel— NVIDIA/AMD/unknown vendor × fp4/fp4fp8/fp8/bf16/int4/fallback (6 cases)· <precision>suffixPrecision: …on hover· NVFP4 / FP8in legend?unofficialrun=<id>overlay legend entry includes precision suffixNote
Low Risk
UI-only labeling changes in inference charts with unit tests; no auth, data, or API behavior changes.
Overview
Inference charts now show vendor-specific FP4 names (NVFP4 on NVIDIA, MXFP4 on AMD) instead of generic
FP4, via newgetPrecisionDisplayLabelinconstants.ts(usesHW_REGISTRYvendor;fp4fp8becomes e.g.NVFP4+FP8; other precisions still go throughgetPrecisionLabel).Legend entries for official hardware and unofficial-run overlays append active precisions after
·, sorted byPRECISION_OPTIONSand joined with/when multiple are selected. Line labels on rooflines use the same helper when more than one precision is visible.Chart tooltip adds an optional
Precision:row when the point payload includes precision. Unit tests cover NVIDIA/AMD/unknown vendors and main precision strings.Reviewed by Cursor Bugbot for commit 792177c. Bugbot is set up for automated code reviews on this repo. Configure here.