Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/PdfParser/Type/PdfDictionary.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ public static function parse(Tokenizer $tokenizer, StreamReader $streamReader, P
break;
}

$entries[$key->value] = $value;
// ensure unique entries
$entries[PdfName::escape(PdfName::unescape($key->value))] = $value;
}

$v = new self();
Expand Down
24 changes: 23 additions & 1 deletion src/PdfParser/Type/PdfName.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,33 @@ public static function unescape($value)
return $value;
}

return \preg_replace_callback('/#([a-fA-F\d]{2})/', function ($matches) {
return \preg_replace_callback('/#([a-fA-F\d]{2})/', static function ($matches) {
return \chr(\hexdec($matches[1]));
}, $value);
}

/**
* Escapes a name string.
*
* @param string $value
* @return string
*/
public static function escape(string $value): string
{
$pattern = '/[\x00-\x21\x7E-\xFF()<>\[\]{}\/%#]/';
if (!\preg_match($pattern, $value)) {
return $value;
}

return \preg_replace_callback(
$pattern,
static function ($matches) {
return '#' . \substr('00' . \dechex(\ord($matches[0])), -2);
},
$value
);
}

/**
* Helper method to create an instance.
*
Expand Down
16 changes: 16 additions & 0 deletions tests/functional/FpdiTraitTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,22 @@ public function writePdfTypeProvider()
"AnyToken\n" .
"endobj\n"
],
[
PdfDictionary::create(['A B' => PdfName::create('A B')]),
"<</A B /A B >>\n" // invalid structure but correct behavior
],
[
PdfDictionary::create(['A B' => PdfName::create(PdfName::escape('A B'))]),
"<</A B /A#20B >>\n" // invalid structure but correct behavior
],
[
PdfDictionary::create([PdfName::escape('A B') => PdfName::create(PdfName::escape('A B'))]),
"<</A#20B /A#20B >>\n"
],
[
PdfDictionary::create(['#41' => PdfName::create('#41')]),
"<</#41 /#41 >>\n"
],
];
}

Expand Down
25 changes: 24 additions & 1 deletion tests/functional/PdfParser/Type/PdfDictionaryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use PHPUnit\Framework\TestCase;
use setasign\Fpdi\PdfParser\PdfParser;
use setasign\Fpdi\PdfParser\StreamReader;
use setasign\Fpdi\PdfParser\Type\PdfArray;
use setasign\Fpdi\PdfParser\Type\PdfDictionary;
use setasign\Fpdi\PdfParser\Type\PdfHexString;
use setasign\Fpdi\PdfParser\Type\PdfName;
Expand Down Expand Up @@ -113,7 +114,29 @@ public function parseProvider()
'A' => PdfName::create('B')
])
],
// @todo
[
'/A 123/#41 321>>',
PdfDictionary::create([
'A' => PdfNumeric::create(321)
])
],
[
'/#41 123/A 321>>',
PdfDictionary::create([
'A' => PdfNumeric::create(321)
])
],
[
'/Rect [1 2 3 4]/Re#63t[5 6 7 8]>>',
PdfDictionary::create([
'Rect' => PdfArray::create([
PdfNumeric::create(5),
PdfNumeric::create(6),
PdfNumeric::create(7),
PdfNumeric::create(8),
])
])
]
];

return $data;
Expand Down
Loading