Fix render startup after AR authorization - #7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts renderer startup sequencing so AR world tracking authorization and ARSession startup complete successfully before the render thread begins, reducing the chance of starting rendering in an unauthorized/invalid AR state.
Changes:
- Delay starting the render thread until after world tracking authorization is granted.
- Start rendering only after
arSession.run([worldTracking])succeeds. - Extract render-thread creation into a dedicated helper method.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
This is a follow-up to PR #6 and addresses review comment 3815195684.