Skip to content

fix(wasm): syntax update - #54

Merged
jeffcharles merged 2 commits into
Shopify:mainfrom
xav-ie:fix-example
Sep 25, 2026
Merged

jeffcharles merged 2 commits into
Shopify:mainfrom
xav-ie:fix-example

Conversation

@xav-ie

@xav-ie xav-ie commented Dec 4, 2024 •

Copy link
Copy Markdown
Contributor

Whenver I cloned the repo, because of the loose locking of deps, I have some newer lock that does not work. I am very new to rust and wasm. This PR made it work for me.
image

Something about needing then and else for if statements, get_local has become local.get and some i32 nonsense. Feel free to close if I was supposed to run differently than:

cargo run --example basic

@xav-ie

xav-ie commented Dec 4, 2024

Copy link
Copy Markdown
Contributor Author

I have signed the CLA!

@xav-ie
xav-ie marked this pull request as ready for review December 4, 2024 21:50
@xav-ie xav-ie closed this Sep 24, 2026
@xav-ie xav-ie reopened this Sep 24, 2026
@xav-ie
xav-ie requested a review from a team as a code owner September 24, 2026 15:24
@xav-ie
xav-ie requested review from jeffcharles and removed request for a team September 24, 2026 15:24
@jeffcharles

Copy link
Copy Markdown
Contributor

Thank you! Sorry this took so long.

@jeffcharles
jeffcharles merged commit be7a1b8 into Shopify:main Sep 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants