Skip to content

[3.0] Give each action subclass its own instance in ActionTrait::load() #9321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertlast wants to merge 1 commit into
base: release-3.0
Choose a base branch
from
+4 −1
Open

[3.0] Give each action subclass its own instance in ActionTrait::load() #9321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/ActionTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ public function canShowDebuggingInfo(): bool
*/
public static function load(): static
{
if (!isset(static::$obj)) {
// A static property is shared with every descendant class that doesn't
// redeclare it, so $obj might currently hold an instance of a relative
// of this class rather than an instance of this class itself.
if (!isset(static::$obj) || static::$obj::class !== static::class) {
static::$obj = new static();
}

Expand Down
Loading