[3.0] Theme split (wave 1, part 3) — Drop the unused jQuery Custom Scrollbar - #9334
Merged
live627 merged 2 commits intoAug 2, 2026
Merged
Conversation
…rollbar The plugin and its stylesheet are loaded on every page for every logged-in member, and nothing calls customScrollbar(). Remove both files, the two loader calls, and the credit for a library that is no longer bundled. Wave 1, part 3 of breaking up SimpleMachines#7933. Co-Authored-By: John Rayes <live627@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Closed
albertlast
force-pushed
the
3.0/theme-scrollbar
branch
from
August 1, 2026 07:28
85b3b38 to
a0158a5
Compare
Contributor
|
this related CSS rule can go SMF/Themes/default/css/index.css Lines 926 to 928 in fcbc3cb |
Review feedback on SimpleMachines#9334: .top_menu.scrollable capped #pm_menu and #alerts_menu at 30em so the custom scrollbar had something to scroll. Nothing ever called customScrollbar(), and .top_menu declares no overflow, so the rule only made long lists spill outside the menu's border instead of growing it. With the plugin gone it has no reason to stay. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
live627
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 1, part 3 of breaking up #7933. No theme templates touched.
Theme::loadJavaScript()loadsjquery.custom-scrollbar.jsand its stylesheet on every page for every logged-in member:Nothing calls
customScrollbar(). GreppingSources/andThemes/default/forcustomScrollbar,custom-scrollbar,smf_jquery_scrollbarandsmf_scrollbarfinds only the plugin itself and these two lines. So it is 942 lines of JS and CSS downloaded and parsed for nothing.Removes both files, both loader calls, and the credit entry, since the library is no longer bundled. #7933 leaves the credit behind; that looks like an oversight rather than a decision.
Not included: #7933 also adds
defertosmf_jquery_plugins.jsandtheme.jsin the same block. That is a separate change with its own risks, so it is left for the part that deals with script loading.Testing
jQuery.fn.customScrollbarisundefined— confirming nothing was relying on it.🤖 Generated with Claude Code