[3.0] Theme split (wave 4, part 7) — make the admin and moderation menu a nav landmark - #9392
Merged
live627 merged 1 commit intoAug 9, 2026
Conversation
The main menu and the breadcrumb became landmarks in wave 3; the menu down the side of the administration and moderation centres did not, so the one navigation block those pages are built around is still an anonymous div to a screen reader. Names it after the centre it belongs to — the label is the string the mobile popup already uses — and brings the mobile toggle inside it, since a control that opens the menu belongs to the menu. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This was referenced Aug 8, 2026
Closed
live627
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the split of #7933, wave 4 part 7. This is the piece deferred out of wave
3 —
GenericMenu.template.php— taken as the landmark change only.#9371 turned the main menu and the breadcrumb into
<nav>landmarks. The menudown the side of the administration and moderation centres was left as it was, so
the one navigation block those pages are built around is still an anonymous
divto a screen reader.
It is now a
<nav>, labelled after the centre it belongs to. The label is thestring the mobile popup heading already uses, so nothing new is needed in
Languages/.The mobile toggle moves inside it as well — a control whose only job is to open
the menu belongs to the menu rather than sitting beside it.
Testing
Geometry is identical.
?action=adminat 1280px, on both branches:release-3.0#genericmenuul.dropmenu#admin_contentLandmarks on the page go from
Main Menu,BreadcrumbtoMain Menu,Breadcrumb,Administration Center Menu; on?action=moderatethe third isModeration Center Menu.The mobile menu still works. Below the 560px breakpoint the toggle is
display: flexwith its icon drawn, the popup starts hidden, and clicking thetoggle opens it with all five sections. Above it the toggle is
display: none, asbefore. The CSS reaches the toggle through
a[class^="mobile_generic_menu_"],which is an attribute selector and does not care that it moved.
Not done here
The theme branch makes four other changes to this file that are not landmark
work and want reading rather than copying:
template_generic_menu()loses&$menu_contextand gains a$menu_labelparameter.
.generic_menuwrapper div goes, whichresponsive.cssstill selectsthrough
div[id^="mobile_generic_menu_"] .generic_menu.Utils::$context['tabs']stops being populated as a side effect of drawing themenu. That is the tab resolution change, and
template_generic_menu_tabs()reads what it sets, so the two have to move together.
Lang::getTxt()calls lose theirfile:argument, which would be aregression against
release-3.0.Issues References (Fixes|Related|Closes)
Related to #7933