[3.0] Puts the forum title and logo back in a band of their own - #9427
Merged
live627 merged 2 commits intoAug 9, 2026
Merged
Conversation
Reverts the layout half of SimpleMachines#9373. The top bar goes back above the header holding the user links, the language picker and the search box, and the header goes back to the forum title and the logo on their own between it and the main menu. Reported as SimpleMachines#9423, and confirmed with the author of SimpleMachines#7933 as the direction to take: the merged header is not what people expect of this theme, whatever the theme branch does. The maintenance page and the profile export follow the forum's header, so their wrapper goes back onto the header element with it. Everything SimpleMachines#9374 and SimpleMachines#9375 changed stays as it is - the menu is still a band across the page and the footer is still a flex row. The Go up link points at the top bar again, since that is the first thing on the page once more. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This was referenced Aug 9, 2026
The revert brought back the rule as it was before the top bar was ever tokenised, with its colours written out literally, which is backwards for a file where the band right under it already reads from --mainmenu-*. The values are unchanged. Its background came from the shared gradient rule near the end of the file rather than the #fff in its own rule, so the token holds the gradient and the selector list loses its entry; the border matches the menu band's exactly. Computed background-image, border and box-shadow are identical before and after, and the only difference is the background-color fallback behind the gradient, which the menu band dropped when it was tokenised too. The --header-* tokens stay gone. The header sets no background, border or shadow any more, so tokens for them would describe nothing. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts the layout half of #9373. Confirmed with live627 as the direction to take on #9423: the merged header is not what people expect of this theme, whatever the theme branch does.
Back to:
Measured on the board index at 1280px after the change:
#top_section#header#main_menuwhich is the layout in the "expected result" screenshot on #9423. Checked at 1280px and at 480px, where the search box and the logo drop out as they did before.
Two commits, deliberately separate:
git revert 6fa05ff1fwith the conflicts resolved to keep everything that landed after it.index.cssare the wrong direction for a file where#main_menuright under it already reads from--mainmenu-*, so it gets--topsection-*to match.Values are unchanged by the second commit. The band's background came from the shared gradient rule near the end of the file, not the
#fffin its own rule, so the token holds that gradient and the selector list loses its entry; the border is identical to the menu band's. Computed values before and after:background-imagelinear-gradient(rgb(226,233,243) 0%, rgb(255,255,255) 70%)border-bottom0.571429px solid rgb(187,187,187)box-shadowrgba(0,0,0,0.16) 0px 1px 4px 0pxbackground-colorrgb(255,255,255)rgba(0,0,0,0)The last row is the
/* fallback for some browsers */colour behind an opaque gradient, which#main_menualso dropped when it was tokenised.What is not reverted: #9374 and #9375 stay exactly as they are, so the menu is still a band across the page and the footer is still a flex row. The
<header>landmark from #9371 stays too — only the class moves back onto it.Other consequences:
--header-*tokens and the.user_panelrule existed only for the merged header and go with it. The header sets no background, border or shadow any more, so tokens for those would describe nothing. Nothing else references either; checked acrossThemes/.#top_sectionagain, since that is the first thing on the page once more.MaintenanceTemplate.phpand theExportProfileData.phpXSLT follow the forum's header, so the wrapper class goes back onto the header element in both. That reverts [3.0] Gives the other two copies of the header the same wrapper #9426, which was correct only while the header had an inner wrapper.#9425 is superseded by this and closed — it centred the title and logo in a row that no longer exists.
Issues References (Fixes|Related|Closes)
Fixes #9423
Related #7933