Skip to content

Add tests for Flattening #626

Closed
Closed

Description

@ValerianRey

#625 made the documentation tests not count towards code coverage. codecov didn't raise any alert (maybe it only checks the changed lines of code), but we're now down to 99% code coverage with 8 lines missing in _flattening.py and 3 lines missing in _weighting_bases.py (see https://app.codecov.io/gh/SimplexLab/TorchJD/tree/main/src%2Ftorchjd%2Faggregation). If we add some very simple tests for Flattening, this will be very easily resolved.

Activity

  1. PierreQuinton commented on Mar 9, 2026

    @PierreQuinton
    Contributor

    I think it is good practice to give the responsibility of coverage to unit tests only. I'm pretty sure it will be easy to do (I can do it).

  2. ValerianRey commented on Mar 9, 2026

    @ValerianRey
    MemberAuthor

    I think it is good practice to give the responsibility of coverage to unit tests only. I'm pretty sure it will be easy to do (I can do it).

    I agree. Nice, go ahead! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions