Repository navigation
refactor(aggregation): Rename simplex projection helper - #804
Closed
ValerianRey wants to merge 1 commit into
Closed
ValerianRey wants to merge 1 commit into
ValerianRey wants to merge 1 commit into
Conversation
`_projection2simplex` is imported by MoDo, SDMGrad and the tests, and its sibling helper in `aggregation/_utils` (`pref_vector_to_weighting`) has no leading underscore and spells out "to". Also use `clamp` instead of taking the maximum with a new tensor of zeros. Outputs are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ValerianRey
added
package: aggregation
cc: refactor
github-actions
Bot
changed the title
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_projection2simplex(in the privateaggregation/_utilspackage) is imported byMoDoWeighting,SDMGradWeightingand the tests, while its sibling helperpref_vector_to_weightinghas no leading underscore and spells out "to". It's renamed toproject_onto_simplex, and its last line uses(y - tmax_f).clamp(min=0.0)instead oftorch.max(y - tmax_f, y.new_zeros(m)).Outputs are bit-identical before and after on 6004 random projections (float32/float64, including a NaN input) and on 20 MoDo and 20 SDMGrad calls. The simplex, MoDo and SDMGrad tests pass.
🤖 Generated with Claude Code