Skip to content

separate high lower from low level #11

Description

@bjuergens

Background: dirhash.py contains lots of different functions and no classes.

Problem: it's getting crowded

Solution: Separation of concerns by splitting the functions in to classes:

  • one class for low-level hashing stuff: This are pretty much all private function, and a couple of public ones
  • one class for high-level file-handling-stuff and wrapper for low-level stuff.

todo:

  • choose name for the 2 classes. some first ideas:
    • hash_driver and handler/frontend
    • dirhash and handler
  • move functions, and add private members, class-variables, constructors, etc. accordingly
  • get rid of most global vars (turn them into private members in their respective class)
  • update dirhash_test.py
  • update run.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorimprove code quality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions