[WWSTCERT-13446, WWSTCERT-13450, WWSTCERT-13454, WWSTCERT-13458] SONOFF/SWV1C by yanggx24 · Pull Request #3157 · SmartThingsCommunity/SmartThingsEdgeDrivers

yanggx24 · 2026-07-31T05:46:07Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2026-07-31T09:55:40Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-07-31T09:55:40Z

Profile category check: ✅ Passed - all profiles have a category defined.

github-actions · 2026-07-31T09:56:19Z

Channel deleted.

github-actions · 2026-07-31T09:57:14Z

zigbee-valve_coverage.xml

File	Coverage
All files	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/sinope/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/lazy_load_subdriver.lua	`57%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 1e566cb

github-actions · 2026-07-31T09:57:20Z

Test Results

73 files 544 suites 0s ⏱️
3 301 tests 3 301 ✅ 0 💤 0 ❌
5 294 runs 5 294 ✅ 0 💤 0 ❌

Results for commit 1e566cb.

♻️ This comment has been updated with latest results.

yanggx24 · 2026-08-01T03:02:58Z

Thanks for the review.

Yes, I checked this behavior with the SONOFF SWV1C device. The device uses the Zigbee OnOff cluster for valve control and reports the valve state through the OnOff attribute.

The custom handlers were added to explicitly map:

valve.open / valve.close commands to Zigbee OnOff On / Off
OnOff attribute reports back to SmartThings valve.open / valve.closed events

This is also needed because the device reports the OnOff value as ZCL_DATA_TYPE_UINT8. In Lua, numeric 0 is truthy, so the handler explicitly checks for false and 0 to avoid treating an OFF report as open.

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

ldeora · 2026-08-03T08:16:04Z

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

Has this implementation been tested with the valve left open for longer than ten minutes?

Several Hydro ONE users have reported that the valve closes itself after approximately ten minutes because of its device-side manual watering duration. From the current PR, it appears that Open only sends the standard Zigbee On command and does not read or update the SONOFF 0xFC11 attribute 0x501D (manualDefaultSettings).

Could you confirm whether the tested devices remained physically open beyond ten minutes, and which model and firmware version were used? It would also be useful to know whether newer firmware has removed the default limit or whether the WWST integration is expected to configure 0x501D.

yanggx24 · 2026-08-03T10:22:53Z

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

Has this implementation been tested with the valve left open for longer than ten minutes?

Several Hydro ONE users have reported that the valve closes itself after approximately ten minutes because of its device-side manual watering duration. From the current PR, it appears that Open only sends the standard Zigbee On command and does not read or update the SONOFF 0xFC11 attribute 0x501D (manualDefaultSettings).

Could you confirm whether the tested devices remained physically open beyond ten minutes, and which model and firmware version were used? It would also be useful to know whether newer firmware has removed the default limit or whether the WWST integration is expected to configure 0x501D.

Just now, I tested a 10-minute manual valve opening action, and after the timeout, the device reported an off status, and the UI on the app also updated accordingly.
The firmware version of the tested device is v 1.1.0.
This smartthings driver will not affect the automatic shutdown after 10 minutes. For this device, our plan is to first complete the WWST certification, and then provide more support for private attributes.

ldeora · 2026-08-03T10:40:23Z

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

Has this implementation been tested with the valve left open for longer than ten minutes?
Several Hydro ONE users have reported that the valve closes itself after approximately ten minutes because of its device-side manual watering duration. From the current PR, it appears that Open only sends the standard Zigbee On command and does not read or update the SONOFF 0xFC11 attribute 0x501D (manualDefaultSettings).
Could you confirm whether the tested devices remained physically open beyond ten minutes, and which model and firmware version were used? It would also be useful to know whether newer firmware has removed the default limit or whether the WWST integration is expected to configure 0x501D.

Just now, I tested a 10-minute manual valve opening action, and after the timeout, the device reported an off status, and the UI on the app also updated accordingly.

To make it clear: the valve won't stay open for longer than 10 minutes, even when it was opened "manually" (Zigbee On command)?

yanggx24 · 2026-08-04T01:40:57Z

To make it clear: the valve won't stay open for longer than 10 minutes, even when it was opened "manually" (Zigbee On command)?

Yes.

KKlimczukS · 2026-08-10T10:02:52Z

@yanggx24 Please update Your branch.

yanggx24 · 2026-08-11T03:05:24Z

@yanggx24 Please update Your branch.

I have merged the latest code, is there anything else missing?

KKlimczukS

Please update Your branch

cjswedes

This is close, it seems like the onoff handler override does justify the subdriver, but there are some other things that seem unnecessary in the subdriver.

…vers

KKlimczukS

lgtm

Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com>

KKlimczukS

lgtm

…vers

KKlimczukS · 2026-10-12T09:12:39Z

@yanggx24
Contributor License Agreement (CLA) needs to be signed by You, so we could merge the code.
Please make sure to complete that step on the github.

yanggx24 · 2026-10-12T10:04:27Z

@yanggx24 Contributor License Agreement (CLA) needs to be signed by You, so we could merge the code. Please make sure to complete that step on the github.

The required license/cla check is stuck at “Expected — Waiting for status to be reported”.
Could you please retrigger the CLA check or provide the CLA signing link?

KKlimczukS · 2026-10-12T11:12:23Z

@yanggx24 Contributor License Agreement (CLA) needs to be signed by You, so we could merge the code. Please make sure to complete that step on the github.

The required license/cla check is stuck at “Expected — Waiting for status to be reported”. Could you please retrigger the CLA check or provide the CLA signing link?

@yanggx24 Please check this link: https://cla-assistant.io/SmartThingsCommunity/SmartThingsEdgeDrivers

yanggx24 · 2026-10-13T01:48:00Z

@yanggx24 Please check this link: https://cla-assistant.io/SmartThingsCommunity/SmartThingsEdgeDrivers

OK, I have signed it. Thank you.

…FF/SWV1C (#3157) * feat:sonoff swv valve * Zigbee Valve:modify comment language and file name * Zigbee Valve:Add Sonoff valve subdriver lazy loading * test: fix zigbee valve lazy loading coverage * Fix SONOFF valve command handling * Configure Sonoff valve battery reporting * chore: simplify zigbee-valve license header * chore: remove test_lazy_load_subdriver.lua * Use default SONOFF valve reporting config * fix(zigbee-valve): restore default battery reporting configuration * Fix SONOFF valve command test expectations * Remove unnecessary line breaks in test_sonoff_valve.lua * Update drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com> * Update drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com> * Remove redundant comments from the SONOFF test file --------- Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com>

feat:sonoff swv valve

d3ca759

KKlimczukS requested changes Jul 31, 2026

View reviewed changes

KKlimczukS reviewed Jul 31, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/sonoff/init.lua Outdated

KKlimczukS reviewed Jul 31, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/sonoff/init.lua

KKlimczukS requested a review from cbaumler July 31, 2026 09:59

Zigbee Valve:modify comment language and file name

244e0ee

yanggx24 force-pushed the main branch from 53138de to 244e0ee Compare August 1, 2026 02:44

KKlimczukS mentioned this pull request Aug 3, 2026

[WWSTCERT-12824, WWSTCERT-12828, WWSTCERT-12832, WWSTCERT-12836] fingerprints for Sonoff valves #3027

Closed

6 of 13 tasks

cbaumler requested review from aleclorimer, cjswedes and nand-nor August 4, 2026 17:01

aleclorimer reviewed Aug 4, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/init.lua

aleclorimer reviewed Aug 4, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/init.lua

Zigbee Valve:Add Sonoff valve subdriver lazy loading

539f602

KKlimczukS changed the title ~~SONOFF/SWV1C~~ [WWSTCERT-13085, WWSTCERT-13089, WWSTCERT-13093, WWSTCERT-13097] SONOFF/SWV1C Aug 5, 2026

KKlimczukS requested a review from aleclorimer August 10, 2026 10:02

Merge branch 'SmartThingsCommunity:main' into main

caee9a2

Merge branch 'main' into main

b938a79

KKlimczukS self-requested a review September 23, 2026 16:20

KKlimczukS approved these changes Sep 23, 2026

View reviewed changes

cjswedes reviewed Sep 23, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/init.lua Outdated

Comment thread drivers/SmartThings/zigbee-valve/src/sonoff/init.lua Outdated

yanggx24 added 2 commits September 24, 2026 11:38

Use default SONOFF valve reporting config

dbd6e4c

Merge branch 'main' into main

293f87c

KKlimczukS self-requested a review September 24, 2026 09:19

yanggx24 added 2 commits October 8, 2026 09:40

fix(zigbee-valve): restore default battery reporting configuration

ee923ab

Merge branch 'main' of https://github.com/yanggx24/SmartThingsEdgeDri…

7664d94

…vers

KKlimczukS reviewed Oct 8, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua Outdated

KKlimczukS reviewed Oct 8, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua

Fix SONOFF valve command test expectations

6626f37

KKlimczukS reviewed Oct 8, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua Outdated

Comment thread drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua Outdated

Remove unnecessary line breaks in test_sonoff_valve.lua

b8cf885

KKlimczukS reviewed Oct 8, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua Outdated

Comment thread drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua Outdated

KKlimczukS requested review from KKlimczukS and cjswedes October 8, 2026 10:35

yanggx24 and others added 3 commits October 9, 2026 09:32

Update drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua

82ebeb6

Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com>

Update drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua

2e35b1e

Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com>

Merge branch 'main' into main

3daa3d6

KKlimczukS approved these changes Oct 9, 2026

View reviewed changes

cjswedes approved these changes Oct 9, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-valve/src/test/test_sonoff_valve.lua Outdated

yanggx24 added 2 commits October 10, 2026 09:26

Remove redundant comments from the SONOFF test file

ae0db68

Merge branch 'main' of https://github.com/yanggx24/SmartThingsEdgeDri…

94fc997

…vers

Merge branch 'main' into main

1e566cb

KKlimczukS merged commit 3951deb into SmartThingsCommunity:main Oct 12, 2026
46 of 49 checks passed

Conversation

yanggx24 commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

yanggx24 commented Aug 1, 2026

Uh oh!

ldeora commented Aug 3, 2026

Uh oh!

yanggx24 commented Aug 3, 2026

Uh oh!

ldeora commented Aug 3, 2026

Uh oh!

yanggx24 commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KKlimczukS commented Aug 10, 2026

Uh oh!

yanggx24 commented Aug 11, 2026

Uh oh!

KKlimczukS left a comment

Choose a reason for hiding this comment

Uh oh!

cjswedes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

KKlimczukS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KKlimczukS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KKlimczukS commented Oct 12, 2026

Uh oh!

yanggx24 commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KKlimczukS commented Oct 12, 2026

Uh oh!

Uh oh!

yanggx24 commented Jul 31, 2026 •

edited

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading

yanggx24 commented Aug 4, 2026 •

edited

Loading

yanggx24 commented Oct 12, 2026 •

edited

Loading

yanggx24 commented Oct 13, 2026 •

edited

Loading