Repository navigation
WWST: add Zemismart KES606 four-gang relay/scene switch #3239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zemismart-dev
wants to merge
6
commits into
SmartThingsCommunity:main
Choose a base branch
from
zemismart-dev:codex/kes606-four-gang-certification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
71e1652
Add Zemismart KES606 four-gang relay and scene support
zemismart-dev bc2cd13
Handle composite device driver switching explicitly
zemismart-dev eedb8f5
Support both profile capability representations during transitions
zemismart-dev e1c0c3c
Prevent KES606 acknowledgements from targeting display parent
zemismart-dev 192595d
Add aggregate switch and scene button to KES606 parent
zemismart-dev 09a4655
Address KES606 matcher and nested driver review
zemismart-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
drivers/SmartThings/zigbee-switch/profiles/ts0601-scene-switch-4-gang.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| name: ts0601-scene-switch-4-gang | ||
| components: | ||
| - id: main | ||
| capabilities: | ||
| - id: switch | ||
| version: 1 | ||
| - id: button | ||
| version: 1 | ||
| - id: refresh | ||
| version: 1 | ||
| categories: | ||
| - name: RemoteController | ||
| preferences: | ||
| - title: Indicator Light | ||
| name: lightMode | ||
| required: false | ||
| preferenceType: enumeration | ||
| definition: | ||
| options: | ||
| none: Off | ||
| relay: Follow Relay | ||
| pos: Position Indicator | ||
| default: relay | ||
| - title: Global Power-on State | ||
| name: relayStatus | ||
| required: false | ||
| preferenceType: enumeration | ||
| definition: | ||
| options: | ||
| off: Off | ||
| on: On | ||
| memory: Memory | ||
| default: memory | ||
| - title: Gang 1 Power-on State | ||
| name: relayStatus1 | ||
| required: false | ||
| preferenceType: enumeration | ||
| definition: | ||
| options: | ||
| off: Off | ||
| on: On | ||
| memory: Memory | ||
| default: memory | ||
| - title: Gang 2 Power-on State | ||
| name: relayStatus2 | ||
| required: false | ||
| preferenceType: enumeration | ||
| definition: | ||
| options: | ||
| off: Off | ||
| on: On | ||
| memory: Memory | ||
| default: memory | ||
| - title: Gang 3 Power-on State | ||
| name: relayStatus3 | ||
| required: false | ||
| preferenceType: enumeration | ||
| definition: | ||
| options: | ||
| off: Off | ||
| on: On | ||
| memory: Memory | ||
| default: memory | ||
| - title: Gang 4 Power-on State | ||
| name: relayStatus4 | ||
| required: false | ||
| preferenceType: enumeration | ||
| definition: | ||
| options: | ||
| off: Off | ||
| on: On | ||
| memory: Memory | ||
| default: memory | ||
19 changes: 19 additions & 0 deletions
19
drivers/SmartThings/zigbee-switch/profiles/ts0601-scene-switch-child-scene.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: ts0601-scene-switch-child-scene | ||
| components: | ||
| - id: main | ||
| capabilities: | ||
| - id: button | ||
| version: 1 | ||
| categories: | ||
| - name: RemoteController | ||
| preferences: | ||
| - title: Mode | ||
| name: switchMode | ||
| description: Switch mode shows a controllable relay; scene mode shows a wireless button. | ||
| required: true | ||
| preferenceType: enumeration | ||
| definition: | ||
| options: | ||
| switch: Switch | ||
| scene: Scene | ||
| default: scene |
30 changes: 30 additions & 0 deletions
30
drivers/SmartThings/zigbee-switch/profiles/ts0601-scene-switch-child.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: ts0601-scene-switch-child | ||
| components: | ||
| - id: main | ||
| capabilities: | ||
| - id: switch | ||
| version: 1 | ||
| - id: refresh | ||
| version: 1 | ||
| categories: | ||
| - name: Switch | ||
| preferences: | ||
| - title: Mode | ||
| name: switchMode | ||
| description: Switch mode shows a controllable relay; scene mode shows a wireless button. | ||
| required: true | ||
| preferenceType: enumeration | ||
| definition: | ||
| options: | ||
| switch: Switch | ||
| scene: Scene | ||
| default: switch | ||
| - title: Countdown Seconds | ||
| name: countdownSeconds | ||
| description: Set the relay countdown in seconds; 0 disables the countdown. | ||
| required: false | ||
| preferenceType: integer | ||
| definition: | ||
| minimum: 0 | ||
| maximum: 43200 | ||
| default: 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding your review request:
We would prefer you use the shared preferences where possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I audited the current standard, stse and certifiedpreferences catalogs (90 definitions). The three-state power-on and indicator settings and the 0–43200-second toggle countdown do not have equivalent shared definitions. For example, restorePowerState is Boolean; powerOffMemory adds unsupported reverse behavior; turnOffDelay lacks zero cancellation, the full range and delayed-on behavior.
stse.changeToWirelessSwitchmatches the basic mode function, but replacing our existingswitchModeenum also changes the saved key/type and introduces a false default for existing Scene children. I did not find a documented alias or supported per-device preference-value migration in the current profile/SDK interfaces. Ignoring the new default would leave the displayed setting inconsistent; treating it as an ordinary change risks switching a Scene gang back to relay mode.I have therefore retained the inline definitions and saved settings in this revision. Could you advise whether there is a preferred compatible shared enum or supported migration mechanism for this case? The catalog/schema audit is complete, but I am not claiming a shared-preference conversion.