Skip to content

WWSTCERT-14018 ThorBolt Smart Lock - #3281

Open
cbaumler wants to merge 1 commit into
mainfrom
new_device/WWSTCERT-14018
Open

cbaumler wants to merge 1 commit into
mainfrom
new_device/WWSTCERT-14018

Conversation

@cbaumler

Copy link
Copy Markdown
Contributor

Relevant WWST tickets:

  • WWSTCERT-14018

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Test Results

   73 files    544 suites   0s ⏱️
3 304 tests 3 304 ✅ 0 💤 0 ❌
5 297 runs  5 297 ✅ 0 💤 0 ❌

Results for commit 13e6555.

@github-actions

Copy link
Copy Markdown

matter-lock_coverage.xml

File Coverage
All files 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/unmigrated-matter-lock/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 90% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 13e6555

deviceLabel: ThorBolt Smart Lock
vendorId: 0x164C
productId: 0x0001
deviceProfileName: lock-user-pin-schedule-battery

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are just using lock-modular for new locks going forward. Although, this profile name in the fingerprint is becoming less relevant anyway since the driver will do profile matching on device add anyway.

Regardless, the modular profile supports all the capabilities in this profile. Plus, the trend based on the other fingerprints added recently points to using the lock-modular profile here in the fingerprint as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants