Restore default.version on flake output used by image tooling - #34
Open
TureBentzin with Copilot wants to merge 2 commits into
Open
Restore default.version on flake output used by image tooling#34TureBentzin with Copilot wants to merge 2 commits into
default.version on flake output used by image tooling#34TureBentzin with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: TureBentzin <38729194+TureBentzin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix default output version attribute for compatibility
Restore Sep 8, 2026
default.version on flake output used by image tooling
TureBentzin
approved these changes
Sep 8, 2026
TureBentzin
left a comment
Collaborator
There was a problem hiding this comment.
bentzin@wsl-laptop ~/w/Tablo (copilot/fix-default-output-version) > nix eval --raw .#packages.x86_64-linux.default.version
1.3¶
TureBentzin
marked this pull request as ready for review
September 8, 2026 06:40
Sobottasgithub
approved these changes
Sep 8, 2026
Sobottasgithub
left a comment
Owner
There was a problem hiding this comment.
Its fine but can you merge it on the implement_tql branch?
TureBentzin
approved these changes
Sep 9, 2026
Collaborator
|
I changed the target branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching
packages.x86_64-linux.defaultto asymlinkJoinremoved theversionattribute expected by existing automation (build-image.shvianix eval). This change re-exposesversionon the default package without altering package selection or build outputs.Problem surface
build-image.shreads.#packages.x86_64-linux.default.version.defaultnow points totablo(symlinkJoin), which did not exposeversion.Change
passthru.versionto thetablosymlinkJoinderivation inflake.nix.default = tablounchanged; no output graph reshaping.Result
packages.x86_64-linux.default.versionis available again for existing tooling.