Skip to content

Restore default.version on flake output used by image tooling - #34

Open
TureBentzin with Copilot wants to merge 2 commits into
implement_tqlfrom
copilot/fix-default-output-version
Open

Restore default.version on flake output used by image tooling#34
TureBentzin with Copilot wants to merge 2 commits into
implement_tqlfrom
copilot/fix-default-output-version

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown

Switching packages.x86_64-linux.default to a symlinkJoin removed the version attribute expected by existing automation (build-image.sh via nix eval). This change re-exposes version on the default package without altering package selection or build outputs.

  • Problem surface

    • build-image.sh reads .#packages.x86_64-linux.default.version.
    • default now points to tablo (symlinkJoin), which did not expose version.
  • Change

    • Added passthru.version to the tablo symlinkJoin derivation in flake.nix.
    • Kept default = tablo unchanged; no output graph reshaping.
  • Result

    • packages.x86_64-linux.default.version is available again for existing tooling.
    • No behavioral change to package composition, only metadata compatibility restoration.
tablo = pkgs.symlinkJoin {
  name = "tablo-${version}";
  paths = [ libtabcrypt tablo-node tablo-client tablo-master ];

  passthru = {
    inherit version;
  };
};

Co-authored-by: TureBentzin <38729194+TureBentzin@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix default output version attribute for compatibility Restore default.version on flake output used by image tooling Sep 8, 2026
Copilot AI requested a review from TureBentzin September 8, 2026 06:32

@TureBentzin TureBentzin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bentzin@wsl-laptop ~/w/Tablo (copilot/fix-default-output-version) > nix eval --raw .#packages.x86_64-linux.default.version
1.3¶      

@TureBentzin
TureBentzin marked this pull request as ready for review September 8, 2026 06:40
@Sobottasgithub Sobottasgithub moved this from Todo to Review in Tablo Sep 8, 2026

@Sobottasgithub Sobottasgithub left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its fine but can you merge it on the implement_tql branch?

@Sobottasgithub Sobottasgithub added bug Something isn't working feature New feature or request labels Sep 8, 2026
@TureBentzin
TureBentzin changed the base branch from main to implement_tql September 9, 2026 06:58
@TureBentzin

Copy link
Copy Markdown
Collaborator

I changed the target branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feature New feature or request

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

Existing tooling went incompatible with new outputs

3 participants