Skip to content

SONARJAVA-7220 Fix the quality gate - #6383

Merged
aurelien-coet-sonarsource merged 1 commit into
masterfrom
ac/fix-qg
Oct 21, 2026
Merged

aurelien-coet-sonarsource merged 1 commit into
masterfrom
ac/fix-qg

Conversation

@aurelien-coet-sonarsource

@aurelien-coet-sonarsource aurelien-coet-sonarsource commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary by Gitar

  • Final fields:
    • Made sourceDirs in SpotBugsXmlReportReader and matchers in MethodMatchersList final
    • Marked many check, visitor, and frontend fields as final
  • Array initializers:
    • Replaced new int[] {...} with {...} shorthand in CFGTest and FileLinesVisitorTest
    • Simplified array creation in JavaSensorTest and ContentHashCacheTest

This will update automatically on new commits.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Fix the quality gate SONARJAVA-7220 Fix the quality gate Oct 21, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

SONARJAVA-7220

@gitar-bot

gitar-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · The changes only make existing fields final and simplify test array initializers, leaving runtime behavior and public interfaces unchanged.

Style cleanup marking fields as final in SpotBugsXmlReportReader, MethodMatchersList, and several check and visitor classes, plus simplifying array initializers in CFGTest, FileLinesVisitorTest, JavaSensorTest, and ContentHashCacheTest. No issues found.

Verification Rules 1/2 met
Rules 1 failed 1 passed 1 not applicable

❌ Repository license compliance - LICENSE.txt contains SSALv1 terms, but the central exception for sonar-java requires LGPL-3.0 and no LGPL text is present; confirm the intended license with owners (this PR does not change it).
✅ Internal artifact registries

Functional validation No results

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown
Contributor

@BartLucien BartLucien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aurelien-coet-sonarsource
aurelien-coet-sonarsource merged commit c2bc768 into master Oct 21, 2026
20 checks passed
@aurelien-coet-sonarsource
aurelien-coet-sonarsource deleted the ac/fix-qg branch October 21, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants