[hashicorp-vault-sonar-prod]

No description provided.

[hashicorp-vault-sonar-prod]

gitar master CI is failing: https://next.sonarqube.com/sonarqube/dashboard?id=org.sonarsource.java%3Ajava&branch=master

1. Investigate the failure.
2. If it looks transient or flaky, retry it.
3. If it's a real issue, fix it in this PR.
4. After pushing a fix, recheck the PR's CI status, and keep pushing commits until it passes.
5. If you can't fix it, leave a comment explaining your investigation.
6. If there's nothing to fix, leave a comment with your investigation notes, ending it with exactly "let's close this PR".

SonarQube analysis on master is also failing due to the issues below. This CI-fix PR intentionally starts with an empty commit: it is the workspace where you must remediate these target-branch issues. They are in scope even if they predate this PR or do not appear in its initial diff. Treat them independently from other CI failures; an unrelated transient or flaky failure is not a reason to skip them. For every listed issue, fix it if it is a true positive; otherwise explain why it is false positive or cannot be safely fixed. Do not recommend closing this PR while any listed SonarQube issue remains unaddressed.

Rule references:

• java:S9435: Invert this negated condition and swap the two branches of the ternary.
• java:S9434: Remove this redundant qualifier.

Issues:

• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:72 [java:S9435] (e71265f0-2548-4f5a-98f9-4a98c70e4501)
• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:73 [java:S9435] (d9b0648e-cfc0-4f0d-80af-7a85eb65265d)
• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:74 [java:S9435] (10184a6b-c2cb-4006-b710-03a15c0fd7db)
• java-checks/src/main/java/org/sonar/java/checks/MarkdownJavadocSyntaxCheck.java:144 [java:S9435] (e37b46a6-7f29-43ab-ad15-7928cfb53718)
• java-frontend/src/main/java/org/sonar/java/model/JParser.java:310 [java:S9435] (173e55c1-1419-43ad-b4df-69efa26c9a2b)
• java-frontend/src/main/java/org/sonar/java/ExecutionTimeReport.java:50 [java:S9435] (b6fb1b71-e298-4dcf-a1ea-048033493f81)
• java-checks-testkit/src/main/java/org/sonar/java/checks/verifier/internal/Expectations.java:173 [java:S9435] (268b69bd-2e67-4f60-abc7-d0a04e54b1cf)
• java-checks/src/main/java/org/sonar/java/checks/OneClassInterfacePerFileCheck.java:41 [java:S9434] (930198c9-f750-493a-baa4-9d034e6e7f0a)
• java-surefire/src/main/java/org/sonar/plugins/surefire/data/SurefireStaxHandler.java:122 [java:S9435] (280fb298-c942-48cd-b026-13265d76cb37)

[gitar-bot]

gitar master CI is failing: https://next.sonarqube.com/sonarqube/dashboard?id=org.sonarsource.java%3Ajava&branch=master

1. Investigate the failure.
2. If it looks transient or flaky, retry it.
3. If it's a real issue, fix it in this PR.
4. After pushing a fix, recheck the PR's CI status, and keep pushing commits until it passes.
5. If you can't fix it, leave a comment explaining your investigation.
6. If there's nothing to fix, leave a comment with your investigation notes, ending it with exactly "let's close this PR".

SonarQube analysis on master is also failing due to the issues below. This CI-fix PR intentionally starts with an empty commit: it is the workspace where you must remediate these target-branch issues. They are in scope even if they predate this PR or do not appear in its initial diff. Treat them independently from other CI failures; an unrelated transient or flaky failure is not a reason to skip them. For every listed issue, fix it if it is a true positive; otherwise explain why it is false positive or cannot be safely fixed. Do not recommend closing this PR while any listed SonarQube issue remains unaddressed.

Rule references:

• java:S9435: Invert this negated condition and swap the two branches of the ternary.
• java:S9434: Remove this redundant qualifier.

Issues:

• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:72 [java:S9435] (e71265f0-2548-4f5a-98f9-4a98c70e4501)
• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:73 [java:S9435] (d9b0648e-cfc0-4f0d-80af-7a85eb65265d)
• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:74 [java:S9435] (10184a6b-c2cb-4006-b710-03a15c0fd7db)
• java-checks/src/main/java/org/sonar/java/checks/MarkdownJavadocSyntaxCheck.java:144 [java:S9435] (e37b46a6-7f29-43ab-ad15-7928cfb53718)
• java-frontend/src/main/java/org/sonar/java/model/JParser.java:310 [java:S9435] (173e55c1-1419-43ad-b4df-69efa26c9a2b)
• java-frontend/src/main/java/org/sonar/java/ExecutionTimeReport.java:50 [java:S9435] (b6fb1b71-e298-4dcf-a1ea-048033493f81)
• java-checks-testkit/src/main/java/org/sonar/java/checks/verifier/internal/Expectations.java:173 [java:S9435] (268b69bd-2e67-4f60-abc7-d0a04e54b1cf)
• java-checks/src/main/java/org/sonar/java/checks/OneClassInterfacePerFileCheck.java:41 [java:S9434] (930198c9-f750-493a-baa4-9d034e6e7f0a)
• java-surefire/src/main/java/org/sonar/plugins/surefire/data/SurefireStaxHandler.java:122 [java:S9435] (280fb298-c942-48cd-b026-13265d76cb37)

Investigated the master SonarQube failure. All 9 listed issues were true positives and are fixed in this PR.

• java:S9435 (8 issues): inverted the negated ternary conditions and swapped the branches. Behavior is unchanged. Files: OctalValuesCheck, MarkdownJavadocSyntaxCheck, JParser, ExecutionTimeReport, Expectations, SurefireStaxHandler.
• java:S9434 (1 issue): in OneClassInterfacePerFileCheck, replaced the redundant OneClassInterfacePerFileCheck.this with this.

I could not compile locally because Maven runs offline here and the Develocity extension could not be resolved. The changes were not built or tested, so the PR's CI run is the first compile and test run. No other CI failures were reported for this PR.

[hashicorp-vault-sonar-prod]

gitar master has advanced from bb1dd23c2aaa to 8aa2d98de8db, and its latest CI is still failing: https://next.sonarqube.com/sonarqube/dashboard?id=org.sonarsource.java%3Ajava&branch=master

1. Investigate the failure.
2. If it looks transient or flaky, retry it.
3. If it's a real issue, fix it in this PR, replacing any obsolete fix if the failure has changed.
4. After pushing a fix, recheck the PR's CI status, and keep pushing commits until it passes.
5. If you can't fix it, leave a comment explaining your investigation.
6. If there's nothing to fix, leave a comment with your investigation notes, ending it with exactly "let's close this PR".

SonarQube analysis on master is also failing due to the issues below. This CI-fix PR intentionally starts with an empty commit: it is the workspace where you must remediate these target-branch issues. They are in scope even if they predate this PR or do not appear in its initial diff. Treat them independently from other CI failures; an unrelated transient or flaky failure is not a reason to skip them. For every listed issue, fix it if it is a true positive; otherwise explain why it is false positive or cannot be safely fixed. Do not recommend closing this PR while any listed SonarQube issue remains unaddressed.

Rule references:

• java:S9435: Invert this negated condition and swap the two branches of the ternary.
• java:S9434: Remove this redundant qualifier.

Issues:

• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:72 [java:S9435] (e71265f0-2548-4f5a-98f9-4a98c70e4501)
• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:73 [java:S9435] (d9b0648e-cfc0-4f0d-80af-7a85eb65265d)
• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:74 [java:S9435] (10184a6b-c2cb-4006-b710-03a15c0fd7db)
• java-checks/src/main/java/org/sonar/java/checks/MarkdownJavadocSyntaxCheck.java:144 [java:S9435] (e37b46a6-7f29-43ab-ad15-7928cfb53718)
• java-frontend/src/main/java/org/sonar/java/model/JParser.java:310 [java:S9435] (173e55c1-1419-43ad-b4df-69efa26c9a2b)
• java-frontend/src/main/java/org/sonar/java/ExecutionTimeReport.java:50 [java:S9435] (b6fb1b71-e298-4dcf-a1ea-048033493f81)
• java-checks-testkit/src/main/java/org/sonar/java/checks/verifier/internal/Expectations.java:173 [java:S9435] (268b69bd-2e67-4f60-abc7-d0a04e54b1cf)
• java-checks/src/main/java/org/sonar/java/checks/OneClassInterfacePerFileCheck.java:41 [java:S9434] (930198c9-f750-493a-baa4-9d034e6e7f0a)
• java-surefire/src/main/java/org/sonar/plugins/surefire/data/SurefireStaxHandler.java:122 [java:S9435] (280fb298-c942-48cd-b026-13265d76cb37)

[gitar-bot]

gitar master has advanced from bb1dd23c2aaa to 8aa2d98de8db, and its latest CI is still failing: https://next.sonarqube.com/sonarqube/dashboard?id=org.sonarsource.java%3Ajava&branch=master

1. Investigate the failure.
2. If it looks transient or flaky, retry it.
3. If it's a real issue, fix it in this PR, replacing any obsolete fix if the failure has changed.
4. After pushing a fix, recheck the PR's CI status, and keep pushing commits until it passes.
5. If you can't fix it, leave a comment explaining your investigation.
6. If there's nothing to fix, leave a comment with your investigation notes, ending it with exactly "let's close this PR".

SonarQube analysis on master is also failing due to the issues below. This CI-fix PR intentionally starts with an empty commit: it is the workspace where you must remediate these target-branch issues. They are in scope even if they predate this PR or do not appear in its initial diff. Treat them independently from other CI failures; an unrelated transient or flaky failure is not a reason to skip them. For every listed issue, fix it if it is a true positive; otherwise explain why it is false positive or cannot be safely fixed. Do not recommend closing this PR while any listed SonarQube issue remains unaddressed.

Rule references:

• java:S9435: Invert this negated condition and swap the two branches of the ternary.
• java:S9434: Remove this redundant qualifier.

Issues:

• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:72 [java:S9435] (e71265f0-2548-4f5a-98f9-4a98c70e4501)
• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:73 [java:S9435] (d9b0648e-cfc0-4f0d-80af-7a85eb65265d)
• java-checks/src/main/java/org/sonar/java/checks/OctalValuesCheck.java:74 [java:S9435] (10184a6b-c2cb-4006-b710-03a15c0fd7db)
• java-checks/src/main/java/org/sonar/java/checks/MarkdownJavadocSyntaxCheck.java:144 [java:S9435] (e37b46a6-7f29-43ab-ad15-7928cfb53718)
• java-frontend/src/main/java/org/sonar/java/model/JParser.java:310 [java:S9435] (173e55c1-1419-43ad-b4df-69efa26c9a2b)
• java-frontend/src/main/java/org/sonar/java/ExecutionTimeReport.java:50 [java:S9435] (b6fb1b71-e298-4dcf-a1ea-048033493f81)
• java-checks-testkit/src/main/java/org/sonar/java/checks/verifier/internal/Expectations.java:173 [java:S9435] (268b69bd-2e67-4f60-abc7-d0a04e54b1cf)
• java-checks/src/main/java/org/sonar/java/checks/OneClassInterfacePerFileCheck.java:41 [java:S9434] (930198c9-f750-493a-baa4-9d034e6e7f0a)
• java-surefire/src/main/java/org/sonar/plugins/surefire/data/SurefireStaxHandler.java:122 [java:S9435] (280fb298-c942-48cd-b026-13265d76cb37)

Investigation summary

The master SonarQube failure is made up of nine quality-rule violations, not a flaky or transient build problem. Commit 01c593a on this branch already fixes all nine, and I confirmed each in the current source.

• java:S9435 (negated ternary, 8 issues): each ternary now tests the positive condition, with the branches swapped. Locations: OctalValuesCheck (3 sites, lines 72–74), MarkdownJavadocSyntaxCheck, JParser, ExecutionTimeReport, Expectations and SurefireStaxHandler. The behaviour is unchanged.
• java:S9434 (redundant qualifier): OneClassInterfacePerFileCheck.this is now this.

I merged the latest master (8aa2d98) into the branch so it is current. The previous head's CI checks, including "SonarQube Code Analysis" on this PR, are all passing. I didn't build or run tests locally, and CI hasn't run on the merge commit yet. I'll leave the PR for CI to confirm.

[hashicorp-vault-sonar-prod]

gitar master has advanced from 8aa2d98de8db to e2d0eee4fcf3, and its latest CI is still failing: https://github.com/SonarSource/sonar-java/actions/runs/39790379003/job/119864538381

1. Investigate the failure.
2. If it looks transient or flaky, retry it.
3. If it's a real issue, fix it in this PR, replacing any obsolete fix if the failure has changed.
4. After pushing a fix, recheck the PR's CI status, and keep pushing commits until it passes.
5. If you can't fix it, leave a comment explaining your investigation.
6. If there's nothing to fix, leave a comment with your investigation notes, ending it with exactly "let's close this PR".

[gitar-bot]

gitar master has advanced from 8aa2d98de8db to e2d0eee4fcf3, and its latest CI is still failing: https://github.com/SonarSource/sonar-java/actions/runs/39790379003/job/119864538381

1. Investigate the failure.
2. If it looks transient or flaky, retry it.
3. If it's a real issue, fix it in this PR, replacing any obsolete fix if the failure has changed.
4. After pushing a fix, recheck the PR's CI status, and keep pushing commits until it passes.
5. If you can't fix it, leave a comment explaining your investigation.
6. If there's nothing to fix, leave a comment with your investigation notes, ending it with exactly "let's close this PR".

No push was confirmed in this run. Check the branch before relying on the requested changes.

[hashicorp-vault-sonar-prod]

gitar master has advanced from e2d0eee4fcf3 to 214481ce436b, and its latest CI is still failing: https://github.com/SonarSource/sonar-java/actions/runs/40476996330/job/122098778045

1. Investigate the failure.
2. If it looks transient or flaky, retry it.
3. If it's a real issue, fix it in this PR, replacing any obsolete fix if the failure has changed.
4. After pushing a fix, recheck the PR's CI status, and keep pushing commits until it passes.
5. If you can't fix it, leave a comment explaining your investigation.
6. If there's nothing to fix, leave a comment with your investigation notes, ending it with exactly "let's close this PR".

[gitar-bot]

gitar master has advanced from e2d0eee4fcf3 to 214481ce436b, and its latest CI is still failing: https://github.com/SonarSource/sonar-java/actions/runs/40476996330/job/122098778045

1. Investigate the failure.
2. If it looks transient or flaky, retry it.
3. If it's a real issue, fix it in this PR, replacing any obsolete fix if the failure has changed.
4. After pushing a fix, recheck the PR's CI status, and keep pushing commits until it passes.
5. If you can't fix it, leave a comment explaining your investigation.
6. If there's nothing to fix, leave a comment with your investigation notes, ending it with exactly "let's close this PR".

Investigation summary

The failure on master at 214481ce436b was a transient infrastructure outage, not a code problem.

• Vault secrets retrieval: the config-maven / build-maven steps failed with Response code 500 (Internal Server Error). This hit Test Analyze, Custom Rules and License Check, Plugin QA, Sanity Test and two Ruling QA jobs.
• Artifact downloads: "Build and Unit Test on Windows" got 503 Service Temporarily Unavailable from repox while resolving org.sonarsource.scanner.engine:*:13.17.0.6738.
• No compile errors or test failures appeared in any job. The preceding master commits passed.

Actions taken

1. I reran the failed jobs of run 40476996330. All jobs now pass, including Build, Windows unit tests, Test Analyze, Sanity Test, Plugin QA and every Ruling QA job, and Promote succeeded.
2. I merged the latest master into this branch. The one-line MarkdownJavadocSyntaxCheck change conflicted because master already contains the same fix (closingQuotesFound ? matcher.end() : -1), so I took master's version. The branch now has no diff against master. I checked only that file after the merge; I did not re-verify the other earlier S9435/S9434 fixes beyond the empty diff.

Nothing is left to fix in this PR, and the SonarQube issues it was opened for are already resolved on master. let's close this PR

[gitar-bot]

Code Review ✅ Approved

🔴 High risk · Risk could not be assessed, so high risk was applied as a precaution.

Draft CI-autofix PR from the bot that investigates a red master build and resolves SonarQube java:S9435 and java:S9434 issues. No open findings remain, so the change is approved.

Verification Rules 2/2 met

Functional validation No results

Rules 2 passed 1 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options ✅ Auto-apply

✅ Auto-apply is on → Gitar will commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

✅ Auto-apply	Compact
gitar auto-apply:off	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube