Skip to content

SONARJAVA-7236 PoC: replace the ECJ parser with semsitter #6407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rombirli wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

SONARJAVA-7236 PoC: replace the ECJ parser with semsitter #6407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e15ea96
SONARJAVA-7236 Drop the ECJ parser so the frontend can be replaced
rombirli Oct 26, 2026
8240106
SONARJAVA-7236 Add a semsitter sample with one grammar rule
rombirli Oct 26, 2026
139dc64
SONARJAVA-7236 Lower the plugin JAR size floor after dropping ECJ
rombirli Oct 26, 2026
755b0cf
SONARJAVA-7236 Speak JSONL to the semsitter bridge over stdin and stdout
rombirli Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions java-frontend/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@
</properties>

<dependencies>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>jdt-package</artifactId>
<version>1.9.0.1840</version>
</dependency>

<dependency>
<groupId>org.sonarsource.api.plugin</groupId>
<artifactId>sonar-plugin-api</artifactId>
Expand Down
132 changes: 0 additions & 132 deletions java-frontend/src/main/java/org/eclipse/jdt/core/dom/ASTUtils.java
View file
Open in desktop

This file was deleted.

11 changes: 1 addition & 10 deletions java-frontend/src/main/java/org/sonar/java/ProgressMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.BooleanSupplier;
import org.eclipse.core.runtime.IProgressMonitor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.sonar.java.annotations.VisibleForTesting;

public class ProgressMonitor implements IProgressMonitor, Runnable {
public class ProgressMonitor implements Runnable {

private final Logger logger;
private final long period;
Expand Down Expand Up @@ -84,7 +83,6 @@ public void run() {
}
}

@Override
public void beginTask(String name, int totalWork) {
if (totalWork <= 0) {
unknownTotalWork = true;
Expand All @@ -96,7 +94,6 @@ public void beginTask(String name, int totalWork) {
thread.start();
}

@Override
public void done() {
if (success && analysisProgress.isLastBatch()) {
log("100% analyzed");
Expand All @@ -107,7 +104,6 @@ public void done() {
join();
}

@Override
public boolean isCanceled() {
if (isCanceled.getAsBoolean()) {
log("Batch processing: Cancelled!");
Expand All @@ -116,7 +112,6 @@ public boolean isCanceled() {
return false;
}

@Override
public void setCanceled(boolean value) {
// do nothing
}
Expand All @@ -129,25 +124,21 @@ private void join() {
}
}

@Override
public void worked(int work) {
processedWork += work;
if (processedWork == totalWork) {
success = true;
}
}

@Override
public void internalWorked(double work) {
// do nothing
}

@Override
public void setTaskName(String name) {
// do nothing
}

@Override
public void subTask(String name) {
// do nothing
}
Expand Down
10 changes: 1 addition & 9 deletions java-frontend/src/main/java/org/sonar/java/model/AbstractTypedTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,15 @@
*/
package org.sonar.java.model;

import org.eclipse.jdt.core.dom.ITypeBinding;
import org.sonar.plugins.java.api.semantic.Type;

import javax.annotation.Nullable;

/**
* This class is intended for internal use during semantic analysis and should not be used in checks.
*/
public abstract class AbstractTypedTree extends JavaTree {

@Nullable
public ITypeBinding typeBinding;

public Type symbolType() {
return typeBinding != null
? root.sema.type(typeBinding)
: Type.UNKNOWN;
return Type.UNKNOWN;
}

}
Loading
Loading