Conversation
ZeWaka
commented
Oct 1, 2026
| Token![..] => { | ||
| // Handles unscoped `..()` in some old codebases. | ||
| DMError::new(start, format!("got `..`, expected identifier")).register(self.context); | ||
| DMError::new(start, "got `..`, expected identifier".to_string()).register(self.context); |
| } | ||
|
|
||
| #[test] | ||
| fn collapses_multi_line_invocation() { |
Contributor
Author
There was a problem hiding this comment.
found this important to make sure expansion results in only a single line
Comment on lines
+84
to
+85
| } else { | ||
| continue; |
Contributor
Author
There was a problem hiding this comment.
tldr this line had code but it was already grabbed, part of a multi-line macro or a #if 0
ZeWaka
marked this pull request as ready for review
October 1, 2026 07:16
# Conflicts: # crates/dm-langserver/src/main.rs # crates/dreammaker/src/parser.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #457 by adding a macro expansion preview command to the langserver and langclient
This has a companion PR in the langclient: SpaceManiac/vscode-dm-langclient#65
We basically re-run the preprocessor over our open file buffer and stitch it together so it lines up with the original, while ignoring comments and all directives.