feat: change retriever output to jsonl#106
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe retriever collection format now uses manifest-based compressed JSONL fragments. Dumping streams records into shards, loading performs integrity and semantic preflight validation, and tests, benchmarks, archive handling, documentation, and integration coverage are updated accordingly. ChangesCompressed JSONL collection flow
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant RetrieverDump
participant CompressedJSONLinesWriter
participant CollectionManifest
participant VerifyCollectionFragments
participant GraphDatabase
RetrieverDump->>CompressedJSONLinesWriter: stream node and edge records
CompressedJSONLinesWriter->>CollectionManifest: record path, count, sizes, checksum
VerifyCollectionFragments->>CollectionManifest: read fragment metadata
VerifyCollectionFragments->>GraphDatabase: stream validated records for loading
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@retriever/compression.go`:
- Around line 251-310: Bound the physical JSONL line size in
readCompressedJSONLinesFromReader so ReadBytes cannot accumulate unbounded
decompressed data; track each record’s bytes and fail immediately with a
descriptive decode error when the configured maximum is exceeded, while
preserving normal parsing and EOF handling for lines within the limit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 721f583c-4b6a-4726-bc1d-bb56a9ef77c0
📒 Files selected for processing (17)
README.mdcmd/retriever/README.mdcmd/retriever/bench.gocmd/retriever/retriever_integration_test.goretriever/archive_envelope.goretriever/archive_envelope_test.goretriever/archive_tar_test.goretriever/compression.goretriever/compression_test.goretriever/doc.goretriever/dump.goretriever/dump_test.goretriever/load.goretriever/load_benchmark_test.goretriever/load_test.goretriever/manifest_test.goretriever/types.go
zinic
left a comment
There was a problem hiding this comment.
This looks reasonable to me
Description
Resolves:
Type of Change
Testing
make test_allwithCONNECTION_STRINGset)Screenshots (if appropriate):
Driver Impact
drivers/pg)drivers/neo4j)Checklist
go.mod/go.sumare up to date if dependencies changedSummary by CodeRabbit
New Features
Documentation
Tests