Pin typescript to ~5.3.3 for parser compatibility#85
Merged
Conversation
The bundled @typescript-eslint/parser@5.x only supports TypeScript < 5.4. TypeScript was unpinned, so fresh installs pulled in TS 7.0, causing every lint run to crash with: TypeError: Failed to load parser '@typescript-eslint/parser' ... Cannot read properties of undefined (reading 'BarBarToken') This broke linting across all consuming projects with no code changes on their end. Pinning typescript to ~5.3.3 keeps it within the parser's supported range. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
corinnejean
requested review from
TensAndTwenties,
jeremymccurdy-redspace and
selenaqian
July 16, 2026 13:52
selenaqian
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Linting started failing across all consuming projects — including repos with no code changes — with:
Root cause
springroll-automated-qabundles@typescript-eslint/parser@5.x(via^5.47.0), which only supports TypeScript < 5.4. Buttypescriptwas never pinned, so it was pulled in transitively. When TypeScript 7.0 was published to npm, every fresh install (npm i -g springroll-automated-qainlint.sh) resolved to it. The v5 parser'stypescript-estreereadsts.SyntaxKind.BarBarToken, which no longer exists in TS 7 → crash on load, before any project code is even parsed.Nothing changed in the consuming games — the trigger was purely the upstream TypeScript release combined with our floating dependency.
Note: pinning
typescriptin a consuming project'spackage.jsondoes not fix this, becausesrlintruns as a global install and resolvestypescriptfrom its ownnode_modules. The fix has to live here.Fix
Pin
typescriptto~5.3.3(the newest release within the bundled parser's supported range) as a direct dependency, so the whole tree — includingtypescript-estree— resolves to a compatible version.Verification
Reproduced the crash against a real game repo, then confirmed with this build:
srlint -p src/on the affected game repo → exit 0, no crash (was crashing on load before).var,==, andfor...ofis correctly flagged (no-var,eqeqeq,no-restricted-syntax) — so this restores real linting, not a silent pass.typescriptmoves from a floating5.6.3(peer) to a pinned5.3.3.🤖 Generated with Claude Code