feat(editor): stabilize Editor for Stacks 3 - #519
Open
dancormier wants to merge 36 commits into
Open
dancormier wants to merge 36 commits into
dancormier wants to merge 36 commits into
Conversation
This reverts commit 6fcb021.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore(refactor) - refactor main.yml (#481) * refactor main.yaml * change empty string to null * update name * refactor: update condition * test change * update name * create changeset
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore(new-release) (beta) * Trigger pipeline --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 4c31b99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dancormier
marked this pull request as ready for review
August 26, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prepares Stacks Editor 1.0 as the stable, Stacks 3-compatible release while preserving the maintained Editor 0.15.x line. It reconciles the beta work with current
main, removes beta branding and V2-only markup, and adds release and package-consumer safeguards before publication.Changes
main^3.0.0while retaining stable Icons V6.s-block-linkusage with accessible Stacks V3 menu markupmainJira
Release plan
This PR leaves the repository at
1.0.0-beta.5in Changesets exit mode. The current prerelease state is expected to produce Editor1.0.0with Classic^3.0.0and Icons^6.2.0; verify the exact output in the generated release PR.Merging this PR creates a separately reviewable stable release PR. It does not publish the package. The generated stable changelog will require review before release.
Accessibility
Editor dropdowns now use the documented
s-menustructure and native Settings controls retain their list, checkbox, and link semantics. Browser coverage verifies the rendered structure across Chromium, Firefox, and WebKit.Verification
All automated GitHub checks pass on the current head; reviewers do not need to repeat the standard install, build, lint, unit, or browser-test commands.
Code review
package.jsonrequires stable Stacks Classic^3.0.0and stable Icons V6, with no beta dependency ranges..github/workflows/main.ymlreleases only frommain, applies least-privilege workflow permissions, and gates release automation on lint, unit, browser, package-consumer, and release-configuration jobs.scripts/package-artifact.test.mjspacks and installs the actual tarball, checks every public export, type-checks public imports, and renders separate ESM and CommonJS browser consumers.v0branch separately: its release workflow must remain restricted to stable0.15.xversions published underlegacy-v0without replacing npmlatest.Deploy preview
Use the Netlify deploy preview:
1..inlinelink. Confirm the edit and remove actions are clear icon buttons with compact spacing. Verify Edit opens the populated link form and Remove removes the link while preserving its text.Known follow-up: selected toolbar-item contrast is tracked separately in STACKS-925 and is not part of this release PR.
Changeset
The complete prerelease changeset history is preserved. A final patch changeset records the stable Classic dependency, Stacks 3 presentation fixes, obsolete demo removal, and release preparation.