Repository navigation
fix(ci): run the StackPack validator in CI - #33
Merged
Merged
Conversation
The validate job started stackstate-server instead of the validator, which printed usage and exited 0, so StackPacks shipped unvalidated. Run the validator through its own entrypoint on a digest-pinned current image, reject an invalid fixture so a silent no-op fails, and require successful packaging before image publication.
VioletCranberry
force-pushed
the
run-stackpack-validator
branch
from
October 12, 2026 13:37
05870d9 to
d873421
Compare
craffit
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validate job ran stackstate-server instead of the validator, so it exited 0 without validating anything. This applies the fix from StackVista/suse-stackpacks#26: run the validator through its entrypoint on a digest-pinned current image, add an invalid fixture the job must reject, and publish only after packaging succeeds.
Validation: run locally with the pinned image, all three StackPacks pass and the fixture is rejected with the expected error. Shellcheck and actionlint pass.