Harden NGINX installer reliability across Bash and PowerShell#79
Merged
Conversation
Agent-Logs-Url: https://github.com/Stensel8/Scripts/sessions/f86082a0-fc16-4ec5-9bef-081e6bae05ab Co-authored-by: Stensel8 <102481635+Stensel8@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Stensel8/Scripts/sessions/f86082a0-fc16-4ec5-9bef-081e6bae05ab Co-authored-by: Stensel8 <102481635+Stensel8@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Stensel8
May 18, 2026 18:02
View session
Stensel8
approved these changes
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the NGINX Bash and PowerShell installer scripts to fail fast when dynamic modules are missing or cannot be copied, preventing installs from completing with broken runtime module loading.
Changes:
- Bash: make dynamic-module copy strict, add explicit ACME artifact check, and verify required modules exist post-install.
- PowerShell: fix
pacmanfailure detection using$LASTEXITCODE, harden module copy withtry/catch, and add required-module + ACME artifact verification for parity.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nginx/nginx_installer.sh | Replaces permissive module-copy behavior with strict checks and required-module verification to prevent partial installs. |
| nginx/nginx_installer.ps1 | Corrects native command failure detection and hardens module-copy/verification logic to match Bash behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/Stensel8/Scripts/sessions/d90af641-3257-4c7c-9f20-b3cf821e5c0a Co-authored-by: Stensel8 <102481635+Stensel8@users.noreply.github.com>
…oise Agent-Logs-Url: https://github.com/Stensel8/Scripts/sessions/d90af641-3257-4c7c-9f20-b3cf821e5c0a Co-authored-by: Stensel8 <102481635+Stensel8@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Stensel8/Scripts/sessions/d90af641-3257-4c7c-9f20-b3cf821e5c0a Co-authored-by: Stensel8 <102481635+Stensel8@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Stensel8/Scripts/sessions/d90af641-3257-4c7c-9f20-b3cf821e5c0a Co-authored-by: Stensel8 <102481635+Stensel8@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Stensel8/Scripts/sessions/d90af641-3257-4c7c-9f20-b3cf821e5c0a Co-authored-by: Stensel8 <102481635+Stensel8@users.noreply.github.com>
Stensel8
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.