Skip to content

Harden NGINX installer reliability across Bash and PowerShell#79

Merged
Stensel8 merged 7 commits into
mainfrom
copilot/improve-nginx-build-scripts
May 18, 2026
Merged

Harden NGINX installer reliability across Bash and PowerShell#79
Stensel8 merged 7 commits into
mainfrom
copilot/improve-nginx-build-scripts

Conversation

Copilot AI commented May 18, 2026

Copy link
Copy Markdown
Contributor
  • Investigate CI run states and confirm why checksum workflow is skipped on this PR
  • Review existing workflow files and checksum helper script for bugs and duplication
  • Refactor checksum helper script to cover all nginx dependencies with installer-matching source URLs
  • Add non-interactive apply mode to checksum helper script for CI reuse
  • Simplify update-nginx-checksums workflow to call helper script and avoid duplicate logic
  • Prevent unnecessary reruns by restricting workflow job to renovate actor on renovate branches
  • Run syntax/lint checks for modified scripts and workflow files
  • Re-run parallel validation and summarize remaining issues

Copilot AI and others added 2 commits May 18, 2026 17:58
@Stensel8 Stensel8 marked this pull request as ready for review May 18, 2026 18:03
Copilot AI review requested due to automatic review settings May 18, 2026 18:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the NGINX Bash and PowerShell installer scripts to fail fast when dynamic modules are missing or cannot be copied, preventing installs from completing with broken runtime module loading.

Changes:

  • Bash: make dynamic-module copy strict, add explicit ACME artifact check, and verify required modules exist post-install.
  • PowerShell: fix pacman failure detection using $LASTEXITCODE, harden module copy with try/catch, and add required-module + ACME artifact verification for parity.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
nginx/nginx_installer.sh Replaces permissive module-copy behavior with strict checks and required-module verification to prevent partial installs.
nginx/nginx_installer.ps1 Corrects native command failure detection and hardens module-copy/verification logic to match Bash behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread nginx/nginx_installer.ps1
Copilot AI requested a review from Stensel8 May 18, 2026 18:13
@Stensel8 Stensel8 merged commit 6e0eb59 into main May 18, 2026
5 checks passed
@Stensel8 Stensel8 deleted the copilot/improve-nginx-build-scripts branch May 18, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants