Skip to content

Demo (nie mergen): Rundungsregression im Monatsbericht #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SebastianKrn wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Demo (nie mergen): Rundungsregression im Monatsbericht #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
private static final Logger LOG = LoggerFactory.getLogger(WerkstattService.class);

// eine Instanz fuer alle Threads, hat bis jetzt eh immer funktioniert
private static final SimpleDateFormat DATUM = new SimpleDateFormat("dd.MM.yyyy");

Check warning on line 37 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[DateFormatConstant] DateFormat is not thread-safe, and should not be used as a constant field.

private final JdbcTemplate jdbcTemplate;
private final int ustSatz;
Expand All @@ -54,7 +54,7 @@
return jdbcTemplate.query(
sql,
new RowMapper<Kunde>() {
public Kunde mapRow(ResultSet rs, int rowNum) throws SQLException {

Check warning on line 57 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[MissingOverride] mapRow implements method in RowMapper; expected @OverRide
Kunde k = new Kunde();
k.setId(rs.getLong("id"));
k.setAnrede(rs.getString("anrede"));
Expand All @@ -78,14 +78,14 @@
* Security-Story: Playbook Kap. 4.
*/
public List<Kunde> sucheKunden(String suchbegriff) {
String muster = "%" + suchbegriff.toLowerCase() + "%";

Check warning on line 81 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[StringCaseLocaleUsage] Specify a `Locale` when calling `String#to{Lower,Upper}Case`. (Note: there are multiple suggested fixes; the third may be most appropriate if you're dealing with ASCII Strings.)
String sql =
"SELECT * FROM kunde WHERE lower(nachname) LIKE ? OR lower(vorname) LIKE ? OR lower(ort) LIKE ? ORDER BY nachname";
LOG.debug("Kundensuche: " + suchbegriff);
return jdbcTemplate.query(
sql,
new RowMapper<Kunde>() {
public Kunde mapRow(ResultSet rs, int rowNum) throws SQLException {

Check warning on line 88 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[MissingOverride] mapRow implements method in RowMapper; expected @OverRide
// Mapping nochmal, war schneller als umbauen
Kunde k = new Kunde();
k.setId(rs.getLong("id"));
Expand All @@ -112,7 +112,7 @@
jdbcTemplate.query(
"SELECT * FROM kunde WHERE id = ?",
new RowMapper<Kunde>() {
public Kunde mapRow(ResultSet rs, int rowNum) throws SQLException {

Check warning on line 115 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[MissingOverride] mapRow implements method in RowMapper; expected @OverRide
Kunde k = new Kunde();
k.setId(rs.getLong("id"));
k.setAnrede(rs.getString("anrede"));
Expand Down Expand Up @@ -186,7 +186,7 @@
return jdbcTemplate.query(
sql,
new RowMapper<Fahrzeug>() {
public Fahrzeug mapRow(ResultSet rs, int rowNum) throws SQLException {

Check warning on line 189 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[MissingOverride] mapRow implements method in RowMapper; expected @OverRide
Fahrzeug f = mapFahrzeug(rs);
String nn = rs.getString("nachname");
String vn = rs.getString("vorname");
Expand All @@ -202,7 +202,7 @@
return jdbcTemplate.query(
"SELECT * FROM fahrzeug WHERE kunde_id = ? ORDER BY kennzeichen",
new RowMapper<Fahrzeug>() {
public Fahrzeug mapRow(ResultSet rs, int rowNum) throws SQLException {

Check warning on line 205 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[MissingOverride] mapRow implements method in RowMapper; expected @OverRide
return mapFahrzeug(rs);
}
},
Expand All @@ -214,7 +214,7 @@
jdbcTemplate.query(
"SELECT * FROM fahrzeug WHERE id = ?",
new RowMapper<Fahrzeug>() {
public Fahrzeug mapRow(ResultSet rs, int rowNum) throws SQLException {

Check warning on line 217 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[MissingOverride] mapRow implements method in RowMapper; expected @OverRide
return mapFahrzeug(rs);
}
},
Expand Down Expand Up @@ -297,7 +297,7 @@
return jdbcTemplate.query(
sql,
new RowMapper<Auftrag>() {
public Auftrag mapRow(ResultSet rs, int rowNum) throws SQLException {

Check warning on line 300 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[MissingOverride] mapRow implements method in RowMapper; expected @OverRide
Auftrag a = mapAuftrag(rs);
String nn = rs.getString("nachname");
if (nn != null) {
Expand All @@ -321,7 +321,7 @@
jdbcTemplate.query(
sql,
new RowMapper<Auftrag>() {
public Auftrag mapRow(ResultSet rs, int rowNum) throws SQLException {

Check warning on line 324 in modern/src/main/java/at/werkstatt/crm/service/WerkstattService.java

View workflow job for this annotation

GitHub Actions / modern-build 

[MissingOverride] mapRow implements method in RowMapper; expected @OverRide
Auftrag a = mapAuftrag(rs);
String nn = rs.getString("nachname");
if (nn != null) {
Expand Down Expand Up @@ -649,7 +649,10 @@
b.setMonat(rs.getInt("monat"));
b.setAnzahlAuftraege(rs.getInt("anzahl_auftraege"));
b.setAnzahlRechnungen(rs.getInt("anzahl_rechnungen"));
b.setUmsatzNetto(rs.getDouble("umsatz_netto"));
// DEMO-REGRESSION (PR demo/regression-rundung, never merged): "Umsatz im Bericht
// in ganzen Euro" - plausible as a cleanup, wrong on the wire. The characterization
// golden bericht-monat-2026.json catches it; the page still looks reasonable.
b.setUmsatzNetto(Math.round(rs.getDouble("umsatz_netto")));
b.setUmsatzBrutto(rs.getDouble("umsatz_brutto"));
return b;
}
Expand Down
Loading