Skip to content

Add tactile press feedback to admin buttons#3200

Open
tuguirazvan wants to merge 1 commit into
masterfrom
button-press-feedback
Open

Add tactile press feedback to admin buttons#3200
tuguirazvan wants to merge 1 commit into
masterfrom
button-press-feedback

Conversation

@tuguirazvan

@tuguirazvan tuguirazvan commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

No ticket — this is a design-polish idea from the Actions & Notifications prototype, not a tracked task.

Admin buttons had no press feedback. This adds a subtle tactile "dip" on click so buttons feel physical.

Screenshot / gif to add — the effect is motion, so a short gif shows it best.

In this update,

  1. Primary, secondary, tertiary and red admin buttons scale to 96% on :active and spring back via the existing transition: all 0.2s ease.
  2. The press transform is disabled under prefers-reduced-motion.

CI note: the failing checks are pre-existing and unrelated to this change — Mago fails on master, Cypress fails on all open PRs, and PHP 7.4 is flaky (green on other PRs). This diff is CSS-only (SCSS + compiled frm_admin.css), no PHP/HTML touched.

Summary by CodeRabbit

  • Style
    • Added a visual pressed-state effect to buttons, making them subtly shrink when clicked.
    • Respects reduced-motion preferences by disabling the animation for users who request less motion.

Primary, secondary, tertiary and red admin buttons dip to 96% while
pressed and spring back via the existing transition. Disabled under
prefers-reduced-motion.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7456a514-70ae-4625-aefa-94cd859141db

📥 Commits

Reviewing files that changed from the base of the PR and between 0fd1e6b and 6d5d405.

📒 Files selected for processing (2)
  • css/frm_admin.css
  • resources/scss/admin/components/button/_button.scss

📝 Walkthrough

Walkthrough

Button variants now visually scale down while pressed, with the effect disabled for users who prefer reduced motion. The SCSS source and compiled admin stylesheet are updated.

Changes

Button interaction feedback

Layer / File(s) Summary
Pressed-state styling and accessibility override
resources/scss/admin/components/button/_button.scss, css/frm_admin.css
Primary, secondary, tertiary, and red buttons use transform: scale(.96) while active; a reduced-motion media query resets the transform to none.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: crabcyborg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding pressed-state tactile feedback to admin buttons.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch button-press-feedback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Jul 23, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 0fd1e6b...6d5d405 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jul 23, 2026 12:56p.m. Review ↗
JavaScript Jul 23, 2026 12:56p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@tuguirazvan
tuguirazvan marked this pull request as ready for review July 23, 2026 14:03
@tuguirazvan
tuguirazvan requested a review from Crabcyborg July 23, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants